Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add fixtures for #3044 #3504

Merged
merged 3 commits into from
Jul 10, 2023
Merged

Add fixtures for #3044 #3504

merged 3 commits into from
Jul 10, 2023

Conversation

siddharthkp
Copy link
Member

@siddharthkp siddharthkp commented Jul 10, 2023 •
edited
Loading

Add fixtures for #3044

leading icon and background have the same color, which makes the icon disappear, description does not have enough contrast with the background

@siddharthkp siddharthkp added the skip changeset This change does not need a changelog label Jul 10, 2023
@siddharthkp siddharthkp requested a review from a team July 10, 2023 10:16
@siddharthkp siddharthkp self-assigned this Jul 10, 2023
@siddharthkp siddharthkp requested a review from joshblack July 10, 2023 10:16
@changeset-bot
Copy link

changeset-bot bot commented Jul 10, 2023 •
edited
Loading

⚠️ No Changeset found

Latest commit: 8b83e0c

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 10, 2023 •
edited
Loading

size-limit report 📦

Path Size
dist/browser.esm.js 102.31 KB (0%)
dist/browser.umd.js 102.88 KB (0%)

@siddharthkp siddharthkp temporarily deployed to github-pages July 10, 2023 10:22 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3504 July 10, 2023 10:23 Inactive
@primer primer bot temporarily deployed to github-pages July 10, 2023 10:32 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3504 July 10, 2023 10:32 Inactive
siddharthkp
siddharthkp commented Jul 10, 2023
View reviewed changes
Copy link
Member Author

@siddharthkp siddharthkp left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Updated snapshots!

@siddharthkp siddharthkp mentioned this pull request Jul 10, 2023
Merged
@siddharthkp siddharthkp added this pull request to the merge queue Jul 10, 2023
Merged via the queue into main with commit 4a70ce3 Jul 10, 2023
@siddharthkp siddharthkp deleted the fixtures-3044 branch July 10, 2023 15:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

Assignees

@siddharthkp siddharthkp

Labels
skip changeset This change does not need a changelog
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@siddharthkp @joshblack