Styled component bug cleanup

[kendallgassner]

While working on Stylelint-a11y spike/exploration I noticed a couple of bugs in some styled blocks. This pr fixes those bugs -- they are pretty much nits.

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

• Added/updated tests
• Added/updated documentation
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

[changeset-bot]

🦋 Changeset detected

Latest commit: 0867c26

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/browser.esm.js	102.42 KB (-0.01% 🔽)
dist/browser.umd.js	103 KB (-0.01% 🔽)

[joshblack]

Thanks for this! 🥳

[joshblack]

One note for @mperrotti, it seems like the change here updates some styling for Timeline across light and dark high contrast themes. Specifically, it seems like the line above the item is not being displayed:

I assume that the intent here is for the line above the second item to be displayed? Just wanted to double-check 👀

[kendallgassner]

I'm mostly just waiting to merge this because of the comment above. @joshblack if you don't think waiting is necessary feel free to merge 🙏 .

[mperrotti]

@joshblack - these changes don't look like they should update how any of the styles are rendered. If the Timeline looks different on main, we should consider those to be visual regressions.

[joshblack]

Thanks @mperrotti!

@kendallgassner should be good to go! Thanks again for this, I just added the update snapshots which should trigger updating the snapshots so VRT goes green ✅