Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for custom widths to PageLayout.Pane. #3563

Merged
merged 8 commits into from
Aug 16, 2023

Conversation

radglob
Copy link
Contributor

@radglob radglob commented Jul 25, 2023

Adds option to pass custom widths to the width prop of PageLayout.Pane to support specific widths outside those defined in the component.

Closes #3419

Screenshots

Please provide before/after screenshots for any visual changes

Merge checklist

  • Added/updated tests
  • Added/updated documentation
  • Changes are SSR compatible
  • Tested in Chrome
  • Tested in Firefox
  • Tested in Safari
  • Tested in Edge

Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.

@radglob radglob requested review from a team and mperrotti July 25, 2023 19:34
@changeset-bot
Copy link

changeset-bot bot commented Jul 25, 2023

🦋 Changeset detected

Latest commit: 79e1ad9

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Jul 25, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 103.74 KB (+0.08% 🔺)
dist/browser.umd.js 104.3 KB (+0.07% 🔺)

@radglob radglob temporarily deployed to github-pages July 25, 2023 19:43 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3563 July 25, 2023 19:44 Inactive
@radglob radglob temporarily deployed to github-pages July 25, 2023 20:01 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3563 July 25, 2023 20:02 Inactive
@radglob radglob temporarily deployed to github-pages July 26, 2023 17:43 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3563 July 26, 2023 17:43 Inactive
@radglob radglob temporarily deployed to github-pages July 26, 2023 18:43 — with GitHub Actions Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-3563 July 26, 2023 18:44 Inactive
Copy link
Member

@joshblack joshblack left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Just had a question about units but that's really it 👀

src/PageLayout/PageLayout.tsx Show resolved Hide resolved
@radglob radglob added this pull request to the merge queue Aug 16, 2023
Merged via the queue into main with commit 3bb6dc8 Aug 16, 2023
@radglob radglob deleted the pagelayout-pane-custom-widths branch August 16, 2023 16:54
This was referenced Aug 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow custom widths for PageLayout.Pane
2 participants