Expose useSlots from drafts
#3609
Merged
+9
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 37c61bd The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
siddharthkp
reviewed
Aug 9, 2023
siddharthkp
reviewed
Aug 9, 2023
siddharthkp
reviewed
Aug 9, 2023
siddharthkp
temporarily deployed
to
github-pages
GitHub Actions
Inactive
iansan5653
changed the title
useSlots from drafts/hooksuseSlots from drafts
This was referenced Aug 10, 2023
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per #3604, we'd like to eventually move the
MarkdownEditorcomponent back into the internal GitHub codebase. This component depends on the slots pattern, which is internal to this library. So as a prerequisite for moving the component, we need to expose theuseSlotshook.This will also be very useful for building other composable components.
Given the volatile nature of this hook, I've decided to expose it from
draftsso it can still be changed and experimented with: