chore(dependencies): Upgrade @primer/octicons-react to v19.7.0
#3692
Conversation
🦋 Changeset detectedLatest commit: e89a8a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
broccolinisoup
changed the title
@primer/react-octicons to v 19.7.0@primer/react-octicons to v19.7.0
broccolinisoup
changed the title
@primer/react-octicons to v19.7.0@primer/octicons-react to v19.7.0
| @@ -100,7 +100,7 @@ | |||
| "@github/relative-time-element": "^4.1.2", | |||
| "@lit-labs/react": "^2.0.1", | |||
| "@primer/behaviors": "^1.3.4", | |||
| "@primer/octicons-react": "^19.3.0", | |||
| "@primer/octicons-react": "^19.7.0", | |||
There was a problem hiding this comment.
Question: I also have an upgrade PR at dotcom https://github.com/github/github/pull/286206 as well and in the diff, there are so many icons in node_modules/@primer/react/node_modules/@primer/octicons-react are deleted. I am a bit confused by this. Does that happen because of npm workspaces that these icons are coming from node_modules/@primer/octicons-react?
There was a problem hiding this comment.
@broccolinisoup I think you're right, now that @primer/octicons-react can properly be hoisted we're now seeing all of the ones in the nested node_modules being removed.
Updates the
@primer/octicons-reactto v19.7.0Changelog since the last upgrade:
Merge checklist
Take a look at the What we look for in reviews section of the contributing guidelines for more information on how we review PRs.