Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(examples): update Next.js to use same react, react-dom as @primer/react #3718

Merged
merged 1 commit into from
Sep 7, 2023

Conversation

joshblack
Copy link
Member

Unfortunately, our Next.js example is failing due to multiple versions of React being used. This leads to a rules of hook violation and means that the example no longer runs.

This PR introduces a temporary solution to reference react and react-dom from the top-level node_modules folder which is shared with @primer/react. In the future, this should be supported through NPM workspaces instead of linking to node_modules directly.

@joshblack joshblack requested review from a team and mperrotti September 7, 2023 17:15
@changeset-bot
Copy link

changeset-bot bot commented Sep 7, 2023

⚠️ No Changeset found

Latest commit: 2127273

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions
Copy link
Contributor

github-actions bot commented Sep 7, 2023

size-limit report 📦

Path Size
dist/browser.esm.js 100.69 KB (0%)
dist/browser.umd.js 101.27 KB (0%)

Copy link
Member

@broccolinisoup broccolinisoup left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Love how you solved this 🔥 This is so helpful! Thank you so much 🙏🏻

@joshblack joshblack added the skip changeset This change does not need a changelog label Sep 7, 2023
@joshblack joshblack added this pull request to the merge queue Sep 7, 2023
Merged via the queue into main with commit 7613131 Sep 7, 2023
@joshblack joshblack deleted the chore/update-nextjs-example branch September 7, 2023 21:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants