Allow Button to break-word for extra long labels (edge cases)

[langermank]

Closes #

Changelog

New

Changed

Removed

Rollout strategy

• Patch release
• Minor release
• Major release; if selected, include a written rollout or migration plan
• None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

• Added/updated tests
• Added/updated documentation
• Added/updated previews (Storybook)
• Changes are SSR compatible
• Tested in Chrome
• Tested in Firefox
• Tested in Safari
• Tested in Edge
• (GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

[changeset-bot]

⚠️ No Changeset found

Latest commit: 9fb8940

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[github-actions]

size-limit report 📦

Path	Size
dist/browser.esm.js	104.61 KB (+0.13% 🔺)
dist/browser.umd.js	105.25 KB (+0.14% 🔺)

[mperrotti]

I have a path forward for preserving the top and bottom padding for buttons with wrapping lines of text.

We can set the following styles on the "buttonContent" container element:

align-self: stretch;
padding-block: calc(var(--control-{size}-paddingBlock, {fallback}) - 2px)

These styles force .buttonContent to fill the height of the button, then adds the correct amount of padding minus the top and bottom borders.

[mperrotti]

Talked to Katie about my idea on Slack and got the go-ahead to push up changes.

[mperrotti]

Idk if I can approve these changes since I pushed a commit, but I'm trying it anyway.

@langermank - we just need a changeset.

[pksjce]

Hi 👋 Thanks for the changes @langermank!
As far as I understand this change is a potential fix for https://github.com/github/accessibility-audits/issues/4690

On deeper investigation, I found that the particular bug is probably a rails issue because it looks like this is the source code for the bug mentioned in the issue. So I don't think this particular PR solves any reported issues.

Other things to consider are

1. This could potentially be an issue in PRC too. Esp with a Button in a container like a Dialog. We can see it is broken in the Dialog stories which currently uses the deprecated Button component. We'd need to refactor it to the latest Button to confirm this.
2. If a Button is present directly on a page, it's not an issue because even on the highest zoom, the page will comfortably overflow and the user will be able to scroll across to view all of the button text (unlike in a dialog where it simply gets cut off).
3. A cursory investigation in dotcom shows that buttons can have long and dynamic texts frequently. I wonder how this PR affects them. Do you think we can get some input from product devs to get an insight into this? Do you know whom we can add to this review?

[github-actions]

Hi! This pull request has been marked as stale because it has been open with no activity for 60 days. You can comment on the pull request or remove the stale label to keep it open. If you do nothing, this pull request will be closed in 7 days.