SelectPanel2: Responsive variants #4277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 4fba95a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
siddharthkp
added
bug
size-limit report 📦
|
joshblack
approved these changes
Mar 15, 2024
Merged
siddharthkp
changed the title
siddharthkp
changed the title
siddharthkp
changed the title
|
@siddharthkp di.. did you just resize your browser aaaa |
lukasoppermann
pushed a commit
that referenced
this pull request
Apr 16, 2024
* cleanup: outdated comment * full screen based on media query * automated responsive button size * use ResponsiveVariants * add responsive story * add bottom-sheet styles * Create proud-ears-travel.md * add matchMedia mock to test-helpers * Revert "add matchMedia mock to test-helpers" This reverts commit d71e0f6. * mock matchMedia for SelectPanel test
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
which let's you do things like
Play around with it on storybook or watch this video:
selectpanel-responsive.mov