Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Banner): add banner component #4335
feat(Banner): add banner component #4335
Changes from all commits
6f53c42
e7ecf41
9afaad9
73542f6
017ba4e
8405bcf
6136b81
860eea1
8140698
ea248f8
49f0fb1
7fca41e
1fc43e9
107f0ee
c418441
3952918
e627264
beeaf2f
fd2d938
b4797a8
6f39e0b
b838530
b0cb281
f38a562
e7ff35a
d139a86
c82781e
8f547e3
a555ba2
17c0384
21b5854
a219f7e
17893b2
36f9cea
3dbbeb6
6c54463
f0a4d14
fe93241
b628857
2f753ba
59299d7
2f520a7
068b0da
b3c8e93
0e9f8e1
3f91ca0
42fe2bf
54a70f4
167c43b
fe5b3ed
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though I understand that heading semantics won't be conveyed through a live region, I'm wondering whether it would make sense to encourage including it as part of the live region announcement since it may contain information that isn't part of the description. 🤔
What would that look like?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khiga8 would something like this maybe work?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
To reduce redundancy around the heading text appearing in the banner twice for screen reader users, would something like this be possible?
cc: @ichelsea if you have other thoughts!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@khiga8 I bet we could make it work, we could also announce the live region itself if that would be desirable (e.g. something like
Banner as={Status}