Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ActionMenu: Add id to ActionMenu.Anchor types #4385

Merged
merged 3 commits into from
Mar 19, 2024
Merged

ActionMenu: Add id to ActionMenu.Anchor types #4385

merged 3 commits into from
Mar 19, 2024

Conversation

broccolinisoup
Copy link
Member

@broccolinisoup broccolinisoup commented Mar 13, 2024 •
edited
Loading

Closes #4299

Changelog

In #3897, we introduced accepting id for ActionMenu.Button and ActionMenu.Anchor and passing this down to the rendered anchor/button. It was just the types were missing.

New

Add and optional string type id to ActionMenu.Anchor

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 13, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: fb36b67

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 13, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 87.57 KB (0%)
packages/react/dist/browser.umd.js 87.96 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4385 March 13, 2024 03:16 Inactive
@broccolinisoup broccolinisoup marked this pull request as ready for review March 13, 2024 03:18
@broccolinisoup broccolinisoup requested a review from a team as a code owner March 13, 2024 03:18
@broccolinisoup broccolinisoup mentioned this pull request Mar 13, 2024
Closed
siddharthkp
siddharthkp approved these changes Mar 13, 2024
View reviewed changes
Copy link
Member

@siddharthkp siddharthkp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Kudos!

@broccolinisoup broccolinisoup added this pull request to the merge queue Mar 19, 2024
Merged via the queue into main with commit 254e289 Mar 19, 2024
30 checks passed
@broccolinisoup broccolinisoup deleted the action-menu-anchor-id branch March 19, 2024 05:23
@primer primer bot mentioned this pull request Mar 19, 2024
Merged
lukasoppermann pushed a commit that referenced this pull request Apr 16, 2024
@broccolinisoup @lukasoppermann
ActionMenu: Add id to ActionMenu.Anchor types (#4385)
2bee4bb 
* Add id to the type for ActionMenu.Anchor

* Create late-peaches-suffer.md

* add an example
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@siddharthkp siddharthkp siddharthkp approved these changes

Assignees

@broccolinisoup broccolinisoup

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ActionMenu.Anchor doesn't accept id param and doesn't pass up child id either
2 participants
@broccolinisoup @siddharthkp