use display name for styled custom element #4403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: a577e67 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
keithamus
force-pushed
the
use-display-name-for-styled-custom-element
branch
from
eadb941
to
a577e67
Compare
owenniblock
approved these changes
Mar 19, 2024
Merged
lukasoppermann
pushed a commit
that referenced
this pull request
Apr 16, 2024
* use display name for styled custom element * changeset * ensure Styled doesnt change displayName
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #4402
This moves the
displayNamevalue set to beforestyled()so that styled components don't prepend thecustom-element__createComponent-prefix. By doing this, a class likecustom-element__createComponent-sc-192p0ln-0becomes justsc-192p0ln-0.Changelog
New
Changed
Custom Element React wrapper now outputs cleaner class names
Removed
Rollout strategy
Testing & Reviewing
Merge checklist