Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use ActionMenu.MenuItemAnchor to implement submenus in ActionBar #4421

Closed
wants to merge 12 commits into from
Closed

Use ActionMenu.MenuItemAnchor to implement submenus in ActionBar #4421

wants to merge 12 commits into from

Conversation

pksjce
Copy link
Contributor

@pksjce pksjce commented Mar 21, 2024 •
edited
Loading

POC for ActionBar submenus using #4386

Screen.Recording.2024-03-21.at.3.33.13.PM.mov

@pksjce pksjce requested a review from a team as a code owner March 21, 2024 04:33
@pksjce pksjce requested a review from mperrotti March 21, 2024 04:33
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Mar 21, 2024 •
edited
Loading

⚠️ No Changeset found

Latest commit: 1e72d9a

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Mar 21, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 87.68 KB (0%)
packages/react/dist/browser.umd.js 88.09 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-4421 March 21, 2024 04:38 Inactive
@pksjce pksjce mentioned this pull request Mar 21, 2024
Merged
13 tasks
@pksjce pksjce marked this pull request as draft March 21, 2024 04:55
Base automatically changed from action-menu/nesting to main March 28, 2024 19:32
@pksjce pksjce closed this Apr 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mperrotti mperrotti Awaiting requested review from mperrotti mperrotti is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pksjce @iansan5653