Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

TreeView: Fix expanding/collapsing item when Space is pressed #4548

Merged
merged 3 commits into from
May 8, 2024
Merged

TreeView: Fix expanding/collapsing item when Space is pressed #4548

merged 3 commits into from
May 8, 2024

Conversation

randall-krauskopf
Copy link
Collaborator

@randall-krauskopf randall-krauskopf commented May 1, 2024 •
edited by siddharthkp
Loading

Before

For some reason my keystroke logger wasn't registering Space events but the pauses before the Return events involves me pressing the Space key but not toggle event occurring

CleanShot.2024-05-01.at.12.26.08.mp4

After

For some reason my keystroke logger wasn't registering Space events but the toggle events that occur before the Return based ones involve me pressing the Space key.

CleanShot.2024-05-01.at.12.26.33.mp4

Changelog

New

Changed

  • Fixes expanding/collapsing sub-items when Space is pressed while a TreeView item is focused

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented May 1, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 70f9ebc

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented May 1, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 88.31 KB (+0.08% 🔺)
packages/react/dist/browser.umd.js 88.57 KB (-0.12% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-4548 May 1, 2024 17:08 Inactive
@randall-krauskopf randall-krauskopf changed the title Account for the {Space} key event TreeView Item: account for the {Space} key event May 1, 2024
@iansan5653 iansan5653 self-assigned this May 8, 2024
@iansan5653 iansan5653 added the component: TreeView Issues related to the TreeView component label May 8, 2024
@iansan5653 iansan5653 marked this pull request as ready for review May 8, 2024 15:57
@iansan5653 iansan5653 requested a review from a team as a code owner May 8, 2024 15:57
@iansan5653 iansan5653 requested a review from joshblack May 8, 2024 15:58
@iansan5653
Copy link
Contributor

@randall-krauskopf is OOO and this looks pretty straightforward, so I'll be taking it over and getting it shipped.

@iansan5653 iansan5653 changed the title TreeView Item: account for the {Space} key event TreeView: Fix expanding/collapsing item when Space is pressed May 8, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-4548 May 8, 2024 16:03 Inactive
@iansan5653 iansan5653 added this pull request to the merge queue May 8, 2024
Merged via the queue into main with commit 95cd867 May 8, 2024
32 checks passed
@iansan5653 iansan5653 deleted the treeview-space-event branch May 8, 2024 16:42
@primer primer bot mentioned this pull request May 8, 2024
Merged
JelloBagel pushed a commit that referenced this pull request May 16, 2024
@randall-krauskopf @iansan5653
@siddharthkp @JelloBagel
TreeView: Fix expanding/collapsing item when Space is pressed (#4548
035d7a0 
)

* Account for the {Space} key event

* Create quiet-lamps-kiss.md

* Update quiet-lamps-kiss.md

---------

Co-authored-by: Ian Sanders <iansan5653@github.com>
Co-authored-by: Siddharth Kshetrapal <siddharthkp@github.com>
This was referenced Jun 11, 2024
Closed
Closed
This was referenced Jun 20, 2024
Closed
Closed
@StemmlerSisters StemmlerSisters mentioned this pull request Jul 16, 2024
Open
@snyk-io snyk-io bot mentioned this pull request Jul 17, 2024
Open
@julitabarelkowska julitabarelkowska mentioned this pull request Jul 17, 2024
Open
@Canadatechmanufacturing Canadatechmanufacturing mentioned this pull request Jul 17, 2024
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

Assignees

@iansan5653 iansan5653

Labels
component: TreeView Issues related to the TreeView component
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@randall-krauskopf @iansan5653 @joshblack @siddharthkp