Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds UnderlinePanels to drafts/ #4550

Merged
merged 37 commits into from
Jun 18, 2024
Merged

Adds UnderlinePanels to drafts/ #4550

merged 37 commits into from
Jun 18, 2024

Conversation

mperrotti
Copy link
Contributor

@mperrotti mperrotti commented May 1, 2024

Relates to https://github.com/github/primer/issues/3108

This component is visually identical to UnderlineNav. The biggest differences are:

  • These are tabs as behave as such
  • It cannot be used as a controlled component
  • No responsive overflow menu (issue)
Kapture.2024-05-01.at.16.34.03.mp4

Changelog

New

Adds UnderlinePanels component

Changed

Refactors UnderlineNav to share component styles with UnderlinePanels

Removed

Nothing removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

This should more or less behave like PVC's UnderlinePanels

Merge checklist

stylistic tweaks

more stylistic tweaks
Copy link

changeset-bot bot commented May 1, 2024

🦋 Changeset detected

Latest commit: 1cbc162

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to storybook-preview-4550 May 2, 2024 18:39 Inactive
@mperrotti mperrotti requested a review from keithamus May 2, 2024 18:39
@mperrotti
Copy link
Contributor Author

Added @keithamus as a reviewer since he's familiar with @github/tab-container-element, which does a lot of the heavy-lifting here.

@mperrotti mperrotti marked this pull request as ready for review May 2, 2024 18:40
@mperrotti mperrotti requested a review from a team as a code owner May 2, 2024 18:40
@github-actions github-actions bot temporarily deployed to storybook-preview-4550 May 2, 2024 18:48 Inactive
Copy link
Contributor

github-actions bot commented May 3, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 90.88 KB (+0.29% 🔺)
packages/react/dist/browser.umd.js 91.07 KB (+0.2% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-4550 May 3, 2024 14:00 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4550 May 3, 2024 14:26 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-4550 May 3, 2024 16:25 Inactive
@mperrotti mperrotti added this pull request to the merge queue Jun 18, 2024
Merged via the queue into main with commit 3e493ba Jun 18, 2024
30 checks passed
@mperrotti mperrotti deleted the mp/underline-panels branch June 18, 2024 23:10
@primer primer bot mentioned this pull request Jun 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants