Update NavList to use the new GroupHeading API and add an as prop to specify the heading level (h3 to match with the default)
#4593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 19a4b77 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
broccolinisoup
temporarily deployed
to
github-pages
GitHub Actions
Inactive
size-limit report 📦
|
broccolinisoup
changed the title
as prop to specify the heading level (h3 to match with the default)
13 tasks
joshblack
approved these changes
May 15, 2024
Merged
JelloBagel
pushed a commit
that referenced
this pull request
May 16, 2024
…o specify the heading level (h3 to match with the default) (#4593) * Add the default heading level with the as prop for NAvlist.Group * Create calm-insects-boil.md * update the comment
13 tasks
This was referenced Jun 11, 2024
This was referenced Jun 20, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While fixing tests on the eslint upgrade PR #4592, I realised that
<NavList.Group title="title">is uses<ActionList.Group title="title">under the hood and with eslint upgrade updating that usage to use the newActionList.GroupHeadingAPI, it throws an error as it requires anasprop to specify the heading level.This PR, updates the old API to the new one on Navlist and specifies the heading level as h3 as per the default value. There shouldn't be any changes in the rendered HTML since we render the same HTML both for old and the new API for backward compatibility
Changelog
New
Changed
titleprop from theActionList.Group title={title}and used<ActionList.GroupHeading>{title}</ActionList.GroupHeading>asprop to the<ActionList.GroupHeading>{title}</ActionList.GroupHeading>since we require it for pure lists, meaning lists that are not in the context of menu or listbox. The value it the default value, h3.Removed
Rollout strategy
Testing & Reviewing
Make sure there is no snapshot changes in the rendered HTML.
Merge checklist