-
Notifications
You must be signed in to change notification settings - Fork 536
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
spike on allowing text #4659
spike on allowing text #4659
Conversation
|
bc1a30a
to
ce69bc9
Compare
size-limit report 📦
|
804153b
into
v-team-trailing-action-action-list
* Add fixes for ActionList * More type fixes * temp type fixes * Add condition for inactive items * add yet another condition * chore(deps): bump changesets/action from 1.4.5 to 1.4.6 (#4282) Bumps [changesets/action](https://github.com/changesets/action) from 1.4.5 to 1.4.6. - [Release notes](https://github.com/changesets/action/releases) - [Changelog](https://github.com/changesets/action/blob/main/CHANGELOG.md) - [Commits](changesets/action@f13b1ba...e2f8e96) --- updated-dependencies: - dependency-name: changesets/action dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * test(e2e): add e2e test for SelectPanel2 default story (#4279) * fix(SelectPanel2): add aria-labelledby to listbox * test(e2e): add e2e test for SelectPanel2 default story * chore: add changeset * test(vrt): update snapshots --------- Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * Address a few v8 color bugs (#4278) * small bug fixes with v8 * Create khaki-schools-lay.md * test(vrt): update snapshots * snippy snaps * test(vrt): update snapshots * test: update snapshots * test: update snapshots * try commenting flakey tests * test: comment out flakey snapshot test --------- Co-authored-by: langermank <langermank@users.noreply.github.com> Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * chore(deps-dev): bump ip from 2.0.0 to 2.0.1 (#4291) Bumps [ip](https://github.com/indutny/node-ip) from 2.0.0 to 2.0.1. - [Commits](indutny/node-ip@v2.0.0...v2.0.1) --- updated-dependencies: - dependency-name: ip dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Change how `ref` is handled * Change types * Update storybook example types * Update types on component * Add another type * Update type in `SegmentedControl` * Add back `li`-only type * Add onto `onSelect` type * Update more types * Type fixes for `LinkItem` * Changes from feedback * Change types * Replace `role="list"` with context * Add feature flag to `ActionList.Item * Add back forwardedRef in cases where valid role is true * Update FF name * Add lint disable * Update FF name * Add changeset * Remove `list` condition * Rename FF * Address feedback * Add feature flag story * Add new test * Add export * Updated forwardRef to be polymorphic * Spike: Add trailingAction to ActionList.Item Co-authored-by: Tyler Jones <tylerjdev@github.com> * Updated forwardRef to be polymorphic * TrailingAction style adjustments * test(vrt): update snapshots * Remove unused story * Limit TrailingAction props * Fix missing href for as link * Add Inactive example * Add styles for `showOnHover` * Fixed href overload issue Co-authored-by: Tyler Jones <tylerjdev@github.com> * Made sure that TrailingAction doesn't show when inactive state Co-authored-by: Tyler Jones <tylerjdev@github.com> * test(vrt): update snapshots * Add fixes for button styles * Fix for flex styles * Update storybookd descriptions * Add block description example * Add tests * Remove FF from tests * update e2e stories * spike on allowing text (#4659) * spike on allowing text * showOnHover support * Add overflow example * Add visual tests * Update from display to visibility * Create calm-crabs-raise.md * Disallow usage in `ActionMenu` * Update ActionList.test.tsx * Remove hover/focus styles * test(vrt): update snapshots * Apply suggestions from code review * Apply suggestions from code review * Fix merge conflict * Remove Hover examples * Remove showOnHover code * Add FF const back * Remove some usage of `hoverStyles` * test(vrt): update snapshots * Add props to TrailingAction * update types Co-authored-by: Josh Black <joshblack@users.noreply.github.com> * update docs --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Tyler Jones <tylerjdev@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Josh Black <joshblack@github.com> Co-authored-by: Josh Black <joshblack@users.noreply.github.com> Co-authored-by: Katie Langerman <18661030+langermank@users.noreply.github.com> Co-authored-by: langermank <langermank@users.noreply.github.com> Co-authored-by: khiga8 <khiga8@users.noreply.github.com> Co-authored-by: TylerJDev <TylerJDev@users.noreply.github.com>
TrailingAction
will render as anIconButton variant="invisible"
orButton variant="invisible"
depending on whether or noticon
is passed intoTrailingAction
.