refactor(VisuallyHidden): update base element from div to span #4691
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: eaa9b66 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
size-limit report 📦
|
TylerJDev
approved these changes
Jun 24, 2024
broccolinisoup
approved these changes
Jun 25, 2024
siddharthkp
approved these changes
Jun 25, 2024
|
@siddharthkp I'm not sure honestly 🤷 curious what you all think. Since this is hidden and position: absolute I would assume that it's not participating in layouts but I am very aware of the fact that I could be missing a scenario where that is true 😅 |
This was referenced Sep 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update our internal utility
VisuallyHiddento use a<span>by default over a<div>. This is due to the fact that a<div>is not allowable in all contexts, for example a<div>cannot be rendered within a<p>. As a result, this helper may not work as intended if a component is within a specific context. Moving over to aspanby default will help with this as it it allowed in all contexts (hopefully).Changelog
New
Changed
divtospanforVisuallyHiddenspaninasRemoved
Rollout strategy