Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(Spinner): update container to use span instead of div #4692

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

joshblack
Copy link
Member

Update container to use span instead of div to prevent issues when Spinner is used within a p tag.

Changelog

New

Changed

  • The container for Spinner is now a span instead of a div

Removed

Rollout strategy

  • Patch release

Testing & Reviewing

  • I believe this should be okay since we explicitly are setting display: inline-flex but let me know if not!

@joshblack joshblack requested a review from mperrotti June 20, 2024 20:34
@joshblack joshblack requested a review from a team as a code owner June 20, 2024 20:34
Copy link

changeset-bot bot commented Jun 20, 2024

⚠️ No Changeset found

Latest commit: 3019d53

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@joshblack joshblack added the skip changeset This change does not need a changelog label Jun 20, 2024
Copy link
Contributor

github-actions bot commented Jun 20, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 90.82 KB (-0.02% 🔽)
packages/react/dist/browser.umd.js 91.14 KB (+0.07% 🔺)

@joshblack joshblack added this pull request to the merge queue Jun 21, 2024
Merged via the queue into main with commit af1cc73 Jun 21, 2024
30 checks passed
@joshblack joshblack deleted the joshblack-patch-1 branch June 21, 2024 18:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants