Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(Breadcrumbs): Convert Breadcrumbs to css module behind feature flag #5150

Merged
merged 16 commits into from
Nov 15, 2024
Merged

feat(Breadcrumbs): Convert Breadcrumbs to css module behind feature flag #5150

merged 16 commits into from
Nov 15, 2024

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Oct 17, 2024 •
edited
Loading

Closes https://github.com/github/primer/issues/4032

Changelog

New

Convert Breadcrumbs to css module behind feature flag

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Merge checklist

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Oct 17, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 2909b80

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Oct 17, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 17, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5150 October 18, 2024 00:01 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5150 October 21, 2024 20:10 Inactive
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Oct 21, 2024 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 100.01 KB (+0.26% 🔺)
packages/react/dist/browser.umd.js 100.33 KB (+0.28% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5150 October 28, 2024 20:37 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 12, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5150 November 12, 2024 20:03 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5150 November 12, 2024 22:24 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5150 November 12, 2024 22:28 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5150 November 12, 2024 23:22 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5150 November 14, 2024 20:42 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5150 November 14, 2024 21:39 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/350875

@jonrohan jonrohan marked this pull request as ready for review November 14, 2024 22:30
@jonrohan jonrohan requested a review from a team as a code owner November 14, 2024 22:30
@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Nov 14, 2024
francinelucca
francinelucca approved these changes Nov 15, 2024
View reviewed changes
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

packages/react/src/Breadcrumbs/__tests__/BreadcrumbsItem.test.tsx Outdated
Comment on lines 24 to 26
it('respects the "as" prop', () => {
expect(render(<Breadcrumbs.Item as="h2" selected />)).toMatchSnapshot()
})
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: is this test different than the one in behavesAsComponent in line 8? (no harm in having it, just curious if there's another purpose)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call, I missed that. 👍🏻

@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 15, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5150 November 15, 2024 05:31 Inactive
@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 15, 2024
@github-actions GitHub Actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 15, 2024
@jonrohan jonrohan added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit e89edbc Nov 15, 2024
43 checks passed
@jonrohan jonrohan deleted the convert_breadcrumbs_to_css_module branch November 15, 2024 06:16
@primer primer bot mentioned this pull request Nov 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@francinelucca francinelucca francinelucca approved these changes

@TylerJDev TylerJDev Awaiting requested review from TylerJDev

Assignees
No one assigned
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jonrohan @francinelucca