Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve the click area for horizontal FormControls (checkboxes and radios) #5190

Merged
merged 8 commits into from
Nov 23, 2024

Conversation

mperrotti
Copy link
Contributor

Closes https://github.com/github/primer/issues/3539

Changelog

New

Changed

  • Changes <label> wrapper of FormControl to put padding directly on the label so the entire row is clickable

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@mperrotti mperrotti requested a review from a team as a code owner October 29, 2024 18:32
Copy link

changeset-bot bot commented Oct 29, 2024

🦋 Changeset detected

Latest commit: 1574716

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Oct 29, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5190 October 29, 2024 18:34 Inactive
Copy link
Contributor

github-actions bot commented Oct 29, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 102.54 KB (+0.05% 🔺)
packages/react/dist/browser.umd.js 102.83 KB (-0.02% 🔽)

@primer primer bot requested a review from a team as a code owner November 22, 2024 23:35
@primer primer bot requested a review from langermank November 22, 2024 23:35
@github-actions github-actions bot temporarily deployed to storybook-preview-5190 November 22, 2024 23:38 Inactive
@mperrotti mperrotti added this pull request to the merge queue Nov 23, 2024
Merged via the queue into main with commit 32c4fe1 Nov 23, 2024
43 checks passed
@mperrotti mperrotti deleted the mp/improve-checkbox-radio-click-area branch November 23, 2024 00:26
@primer primer bot mentioned this pull request Nov 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants