Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(TextInput): Convert TextInput (Part 4) - TextInputAction & TextInputInnerVisualSlot #5276

Merged
merged 7 commits into from
Nov 15, 2024

Conversation

hussam-i-am
Copy link
Collaborator

@hussam-i-am hussam-i-am commented Nov 13, 2024

Changelog

New

Changed

  • Updated TextInputAction to use CSS modules behind feature flag
  • Updated TextInputInnerVisualSlot to use CSS modules behind feature flag
  • Updated snapshots

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

@hussam-i-am hussam-i-am self-assigned this Nov 13, 2024
Copy link

changeset-bot bot commented Nov 13, 2024

🦋 Changeset detected

Latest commit: 9767f0c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@hussam-i-am hussam-i-am changed the title feat(TextInput): Convert TextInput (Part 4) - Update TextInputAction … feat(TextInput): Convert TextInput (Part 4) - TextInputAction & TextInputInnerVisualSlot Nov 13, 2024
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Nov 13, 2024
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented Nov 13, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 99.66 KB (+0.17% 🔺)
packages/react/dist/browser.umd.js 100 KB (+0.2% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5276 November 13, 2024 21:47 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Nov 13, 2024
@hussam-i-am hussam-i-am marked this pull request as ready for review November 13, 2024 23:09
@hussam-i-am hussam-i-am requested a review from a team as a code owner November 13, 2024 23:09
@hussam-i-am
Copy link
Collaborator Author

Failing integration tests are the same owns failing in main #5276

@github-actions github-actions bot temporarily deployed to storybook-preview-5276 November 14, 2024 22:02 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/351115

@primer-integration
Copy link

🔴 golden-jobs completed with status failure.

@hussam-i-am hussam-i-am added this pull request to the merge queue Nov 15, 2024
Merged via the queue into main with commit d91dc54 Nov 15, 2024
43 checks passed
@hussam-i-am hussam-i-am deleted the hussam-i-am/text-input-action-and-visual-slot branch November 15, 2024 17:16
@primer primer bot mentioned this pull request Nov 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: failing Changes in this PR cause breaking changes in gh/gh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants