-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(Popover): Convert Popover to CSS modules behind team feature flag #5300
feat(Popover): Convert Popover to CSS modules behind team feature flag #5300
Conversation
🦋 Changeset detectedLatest commit: 3cdcda9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
…thub.com:primer/react into francinelucca/4139-update-popover-to-css-modules
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/351364 |
🟢 golden-jobs completed with status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome ✨
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
Closes https://github.com/github/primer/issues/4139
Changelog
New
Popover
dev story to testsx
andstyle
props with VRTPopover
module cssChanged
Popover
e2e tests and add new dev storyPopover
to use CSS modules when team feature flag is turned onRollout strategy
Testing & Reviewing
Merge checklist