-
Notifications
You must be signed in to change notification settings - Fork 537
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(ProgressBar): Convert ProgressBar to CSS modules behind team feature flag #5304
Conversation
🦋 Changeset detectedLatest commit: a7161a5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/351565 |
🔴 golden-jobs completed with status |
border-radius: var(--borderRadius-small); | ||
gap: 2px; | ||
|
||
&[data-progress-display='inline'] { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Something we're doing for the data-
attribute selectors is wrapping in :where()
which brings the specificity down on the selector so it's easier to override in dotcom.
&[data-progress-display='inline'] { | |
&:where([data-progress-display='inline']) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks great 👍🏻
Closes https://github.com/github/primer/issues/4304
Changelog
New
ProgressBar
to CSS modules behind team feature flagRollout strategy
Testing & Reviewing
Merge checklist