Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test(Overlay): Add e2e testing #5315

Merged
merged 32 commits into from
Nov 25, 2024
Merged

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Nov 19, 2024

None of the Overlay stories are currently being included in the e2e tests, this PR adds them. Also adds minor accessibility improvement by adding aria-label to overlay stories. Finally, adds dev story for Overlay to test Sx prop (to be used for CSS module migration)

Changelog

New

  • E2e tests for Overlay stories
  • Add aria-label to Overlay stories with dialog (a11y fix)
  • Adds Sx test dev story for Overlay

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Test/Sb changes only

Testing & Reviewing

--

Merge checklist

Copy link

changeset-bot bot commented Nov 19, 2024

⚠️ No Changeset found

Latest commit: 9a918ab

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@francinelucca francinelucca added skip changeset This change does not need a changelog update snapshots labels Nov 19, 2024
@github-actions github-actions bot added the staff Author is a staff member label Nov 19, 2024
@francinelucca francinelucca added component: Overlay and removed staff Author is a staff member labels Nov 19, 2024
@github-actions github-actions bot temporarily deployed to storybook-preview-5315 November 19, 2024 22:39 Inactive
Copy link
Contributor

github-actions bot commented Nov 19, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 102.74 KB (0%)
packages/react/dist/browser.umd.js 103.02 KB (0%)

@francinelucca francinelucca changed the title Francinelucca/overlay e2e testing Test(Overlay): Add e2e testing Nov 19, 2024
…/react into francinelucca/overlay-e2e-testing
@francinelucca francinelucca marked this pull request as ready for review November 25, 2024 21:55
@francinelucca francinelucca requested review from a team as code owners November 25, 2024 21:55
@francinelucca francinelucca added this pull request to the merge queue Nov 25, 2024
Merged via the queue into main with commit 18df436 Nov 25, 2024
43 checks passed
@francinelucca francinelucca deleted the francinelucca/overlay-e2e-testing branch November 25, 2024 22:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: Overlay skip changeset This change does not need a changelog
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants