Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove min-width on leading visuals + add to Selection in ActionList #5411

Merged
merged 13 commits into from
Dec 11, 2024

Conversation

langermank
Copy link
Contributor

Just another fine tuning detail to prep for CSS Modules. This width is causing a bit of blowout sometimes breaking the row layout with 8px gaps.

Copy link

changeset-bot bot commented Dec 10, 2024

🦋 Changeset detected

Latest commit: ccd3096

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Dec 10, 2024
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented Dec 10, 2024

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 102.52 KB (-0.03% 🔽)
packages/react/dist/browser.umd.js 102.88 KB (+0.03% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5411 December 10, 2024 23:37 Inactive
@primer primer bot temporarily deployed to github-pages December 10, 2024 23:39 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5411 December 10, 2024 23:39 Inactive
@primer primer bot temporarily deployed to github-pages December 10, 2024 23:58 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5411 December 10, 2024 23:58 Inactive
@langermank langermank marked this pull request as ready for review December 10, 2024 23:58
@langermank langermank requested review from a team as code owners December 10, 2024 23:58
@langermank langermank changed the title Remove min-width on leading visuals in ActionList Remove min-width on leading visuals + add to Selection in ActionList Dec 11, 2024
@langermank langermank added this pull request to the merge queue Dec 11, 2024
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to failed status checks Dec 11, 2024
@langermank langermank added this pull request to the merge queue Dec 11, 2024
Merged via the queue into main with commit 74d3de4 Dec 11, 2024
42 checks passed
@langermank langermank deleted the rm-min-width-al branch December 11, 2024 00:56
@primer primer bot mentioned this pull request Dec 11, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants