Add className back to TokenBase #5420
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: d02eca8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
integration-tests: recommended
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
TylerDixon
temporarily deployed
to
github-pages
GitHub Actions
Inactive
size-limit report 📦
|
TylerDixon
temporarily deployed
to
github-pages
GitHub Actions
Inactive
francinelucca
added a commit
that referenced
this pull request
Dec 12, 2024
* Add className back to TokenBase * Adding tests and fixing implementation * Create dirty-wasps-behave.md --------- Co-authored-by: Marie Lucca <40550942+francinelucca@users.noreply.github.com>
francinelucca
added a commit
to francinelucca/react
that referenced
this pull request
Dec 30, 2024
* Add className back to TokenBase * Adding tests and fixing implementation * Create dirty-wasps-behave.md --------- Co-authored-by: Marie Lucca <40550942+francinelucca@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to #5271, the
classNameinTokenBasewas part of the...restvariables that were spread onto the token base. Now that theclassNameis directly referenced as part of the feature-flagged token, we need to directly reference it for the non-feature flagged token.Rollout strategy
Testing & Reviewing
Create a
Tokenwith a class name, that class should be on the resulting rendered token.Merge checklist