Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid TypeError in useAnnouncements #5551

Merged
merged 4 commits into from
Jan 16, 2025

Conversation

camertron
Copy link
Contributor

Closes https://github.com/github/primer/issues/4635

Changelog

New

Changed

  1. Fixes an issue in useAnnouncements.tsx causing a TypeError in production. The activeItem variable may be null.

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

- [ ] Added/updated tests
- [ ] Added/updated documentation
- [ ] Added/updated previews (Storybook)

@camertron camertron requested a review from a team as a code owner January 15, 2025 22:42
Copy link

changeset-bot bot commented Jan 15, 2025

🦋 Changeset detected

Latest commit: 67e55f3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@camertron camertron changed the title Avoid accessing properties of undefined in useAnnouncements Avoid TypeError in useAnnouncements Jan 15, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Jan 15, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented Jan 15, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.19 KB (+0.02% 🔺)
packages/react/dist/browser.umd.js 104.57 KB (+0.06% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-5551 January 15, 2025 22:46 Inactive
Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Jan 15, 2025
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/358253

@primer-integration
Copy link

🔴 golden-jobs completed with status failure.

@camertron camertron added this pull request to the merge queue Jan 16, 2025
Merged via the queue into main with commit c0360db Jan 16, 2025
41 of 42 checks passed
@camertron camertron deleted the use_announcements_check_active_item_null branch January 16, 2025 23:20
@primer primer bot mentioned this pull request Jan 16, 2025
camertron added a commit that referenced this pull request Jan 21, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: failing Changes in this PR cause breaking changes in gh/gh
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants