chore(Table): Remove the CSS modules feature flag from the Table component #5788
+84
−464
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 83fa205 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
staff
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
jonrohan
commented
Mar 18, 2025
jonrohan
changed the title
github-actions
bot
added
integration-tests: failing
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/371527 |
|
🟢 golden-jobs completed with status |
github-actions
bot
added
integration-tests: passing
francinelucca
approved these changes
Apr 11, 2025
joshblack
approved these changes
Apr 11, 2025
Merged
hectahertz
pushed a commit
that referenced
this pull request
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR removes the CSS modules feature flag from the
Tablecomponent. The component Table and sub components are used121times in dotcom.Closes https://github.com/github/primer/issues/4307
Changelog
New
Changed
Removed
Removes the CSS modules feature flag from the
Tablecomponents.Rollout strategy
Testing & Reviewing
Using Integration testing.
Merge checklist