Skip to content

Bug fix: className passed to PageLayout twice #5816

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 24, 2025
Merged

Conversation

langermank
Copy link
Contributor

Closes https://github.com/github/primer/issues/4911

Removed the className call from the content wrapper

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Mar 24, 2025

⚠️ No Changeset found

Latest commit: 0427ef8

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@langermank langermank marked this pull request as ready for review March 24, 2025 19:25
@langermank langermank requested a review from a team as a code owner March 24, 2025 19:25
@langermank langermank requested a review from siddharthkp March 24, 2025 19:25
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 24, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented Mar 24, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 105.48 KB (+0.04% 🔺)
packages/react/dist/browser.umd.js 105.85 KB (+0.05% 🔺)

@langermank langermank added this pull request to the merge queue Mar 24, 2025
Merged via the queue into main with commit 59e62c1 Mar 24, 2025
44 checks passed
@langermank langermank deleted the langermank-patch-1 branch March 24, 2025 20:06
@primer primer bot mentioned this pull request Mar 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants