-
Notifications
You must be signed in to change notification settings - Fork 602
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
added default button type to switch button to prevent submit when included in form #5841
base: main
Are you sure you want to change the base?
Conversation
🦋 Changeset detectedLatest commit: d8d938a The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
This PR implements the change for the ToggleSwitch default behavior to act as a button rather than a submit button. I haven't added the full test suite yet, and I'm looking for guidance on what tests would be most valuable for this change. I'm eager to iterate based on your feedback. |
Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
…/react into dwsosa/defaultTypeForSwitchButton
Closes # 5823
#5823
Added a variable to the switch button interface and added a default value of "button" so that the toggleswitch component doesnt default to "submit" which is an issue when the toggleswitch is added to a form
Changelog
New
Changed
Removed
Rollout strategy
Testing & Reviewing
Merge checklist
Jest test result to confirm the type attribute has value "button"
