Remove the CSS modules feature flag from the FormControl component #5851

jamieshark · 2025-03-31T16:17:20Z

Towards https://github.com/github/primer/issues/3812
Redo of Remove the CSS modules feature flag from the FormControl component #5807 after revert

This PR removes the CSS modules feature flag from the FormControl component. The component FormControl is used 509 times in dotcom.

Changelog

New

Changed

Removed

Removes the CSS modules feature flag from the FormControl component.

Rollout strategy

Patch release
Minor release
Major release; if selected, include a written rollout or migration plan
None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Added/updated tests
Added/updated documentation
Added/updated previews (Storybook)
Changes are SSR compatible
Tested in Chrome
Tested in Firefox
Tested in Safari
Tested in Edge
(GitHub staff only) Integration tests pass at github/github (Learn more about how to run integration tests)

…ration.

…les_remove_flag_formcontrol

changeset-bot · 2025-03-31T16:17:23Z

🦋 Changeset detected

Latest commit: f53fd68

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package

Name	Type
@primer/react	Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

github-actions · 2025-03-31T16:17:52Z

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

github-actions · 2025-03-31T16:20:53Z

size-limit report 📦

Path	Size
packages/react/dist/browser.esm.js	104.99 KB (-0.52% 🔽)
packages/react/dist/browser.umd.js	105.38 KB (-0.42% 🔽)

…les_remove_flag_formcontrol

francinelucca · 2025-04-02T14:45:21Z

packages/react/src/internal/components/InputValidation.tsx

+    <Text
+      className={clsx({[classes.InputValidation]: sx !== defaultSxProp})}


confused by this line. these styles are only needed if sx prop is supplied?

ah I think I was confused here, thinking that we would only apply the modules styles if we didn't have custom sx, but I think the idea is that we always apply the styles anyway. I'll make this change!

packages/react/src/FormControl/__tests__/FormControl.test.tsx

primer-integration · 2025-04-02T18:59:49Z

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/370943

primer-integration · 2025-04-02T19:48:24Z

🟢 golden-jobs completed with status success.

github-actions · 2025-04-02T21:08:09Z

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

jamieshark added 10 commits March 21, 2025 13:35

Removes feature flag for FormControl component.

8743c1c

Slightly better naming.

2462383

Changeset.

9132b85

Swaps out Input Validation, starts work on Input Label.

98703b6

Swap out input label component.

48526ac

Adds util function to account for SX dependent components to ease mig…

db982ac

…ration.

Merge commit 'db982acf547431d805bbf79905698260ed2b7506' into css_modu…

964892f

…les_remove_flag_formcontrol

Removes feature flag file from FormControl directory.

e2ebea9

Merge remote-tracking branch 'refs/remotes/origin/main' into css_modu…

023399e

…les_remove_flag_formcontrol

Fixes FormControl label argument, adds test.

dbd984f

github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Mar 31, 2025

jamieshark marked this pull request as ready for review March 31, 2025 16:18

jamieshark requested a review from a team as a code owner March 31, 2025 16:18

jamieshark requested a review from francinelucca March 31, 2025 16:18

jamieshark deployed to github-pages March 31, 2025 16:29 — with GitHub Actions View deployment

github-actions bot temporarily deployed to storybook-preview-5851 March 31, 2025 16:30 Inactive

github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Mar 31, 2025

jamieshark added 2 commits April 1, 2025 16:27

Merge remote-tracking branch 'refs/remotes/origin/main' into css_modu…

daf2f8a

…les_remove_flag_formcontrol

Moves toggle components outside of component.

a050df1

jamieshark deployed to github-pages April 1, 2025 21:47 — with GitHub Actions View deployment

github-actions bot temporarily deployed to storybook-preview-5851 April 1, 2025 21:48 Inactive

francinelucca reviewed Apr 2, 2025

View reviewed changes

jamieshark added 2 commits April 2, 2025 12:04

Address review comments.

e489ddf

Remove unused import.

9c9c641

github-actions bot requested a deployment to storybook-preview-5851 April 2, 2025 17:15 Abandoned

jamieshark deployed to github-pages April 2, 2025 17:33 — with GitHub Actions View deployment

test(vrt): update snapshots

7445e17

primer bot requested a review from a team as a code owner April 2, 2025 19:03

primer bot requested a review from langermank April 2, 2025 19:03

github-actions bot removed the update snapshots label Apr 2, 2025

primer bot deployed to github-pages April 2, 2025 19:17 View deployment

github-actions bot temporarily deployed to storybook-preview-5851 April 2, 2025 19:17 Inactive

jamieshark added the update snapshots label Apr 2, 2025

test(vrt): update snapshots

d43b4b3

github-actions bot removed the update snapshots label Apr 2, 2025

github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Apr 2, 2025

primer bot deployed to github-pages April 2, 2025 20:03 View deployment

github-actions bot temporarily deployed to storybook-preview-5851 April 2, 2025 20:03 Inactive

francinelucca approved these changes Apr 2, 2025

View reviewed changes

jamieshark added the update snapshots label Apr 2, 2025

primer bot deployed to github-pages April 2, 2025 21:06 View deployment

github-actions bot temporarily deployed to storybook-preview-5851 April 2, 2025 21:06 Inactive

test(vrt): update snapshots

f53fd68

github-actions bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed update snapshots labels Apr 2, 2025

primer bot deployed to github-pages April 2, 2025 21:21 View deployment

github-actions bot deployed to storybook-preview-5851 April 2, 2025 21:21 View deployment

jamieshark added this pull request to the merge queue Apr 2, 2025

Merged via the queue into main with commit a812a86 Apr 2, 2025
44 checks passed

jamieshark deleted the css_modules_remove_flag_formcontrol branch April 2, 2025 22:17

primer bot mentioned this pull request Apr 2, 2025

Release tracking #5863

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Remove the CSS modules feature flag from the FormControl component #5851

Remove the CSS modules feature flag from the FormControl component #5851

Uh oh!

jamieshark commented Mar 31, 2025

Uh oh!

changeset-bot bot commented Mar 31, 2025 •

edited

Loading

Uh oh!

github-actions bot commented Mar 31, 2025

Uh oh!

github-actions bot commented Mar 31, 2025 •

edited

Loading

Uh oh!

francinelucca Apr 2, 2025

Uh oh!

jamieshark Apr 2, 2025

Uh oh!

Uh oh!

primer-integration bot commented Apr 2, 2025

Uh oh!

primer-integration bot commented Apr 2, 2025

Uh oh!

github-actions bot commented Apr 2, 2025

Uh oh!

Uh oh!

Uh oh!

		<Text
		className={clsx({[classes.InputValidation]: sx !== defaultSxProp})}

Remove the CSS modules feature flag from the FormControl component #5851

Remove the CSS modules feature flag from the FormControl component #5851

Uh oh!

Conversation

jamieshark commented Mar 31, 2025

Changelog

New

Changed

Removed

Rollout strategy

Testing & Reviewing

Merge checklist

Uh oh!

changeset-bot bot commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🦋 Changeset detected

Uh oh!

github-actions bot commented Mar 31, 2025

Uh oh!

github-actions bot commented Mar 31, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

size-limit report 📦

Uh oh!

francinelucca Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

jamieshark Apr 2, 2025

Choose a reason for hiding this comment

Uh oh!

Uh oh!

primer-integration bot commented Apr 2, 2025

Uh oh!

primer-integration bot commented Apr 2, 2025

Uh oh!

github-actions bot commented Apr 2, 2025

Uh oh!

Uh oh!

Uh oh!

changeset-bot bot commented Mar 31, 2025 •

edited

Loading

github-actions bot commented Mar 31, 2025 •

edited

Loading