Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore(Text): Remove the CSS modules feature flag from the Text component #5868

Merged
merged 20 commits into from
Apr 11, 2025
Merged

chore(Text): Remove the CSS modules feature flag from the Text component #5868

merged 20 commits into from
Apr 11, 2025

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Apr 3, 2025 •
edited
Loading

Closes https://github.com/github/primer/issues/3785

Changelog

New

Changed

Removed

Remove the CSS modules feature flag from the Text component

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

jamieshark and others added 15 commits March 28, 2025 15:25
@jamieshark
Initial clean up of flags.
809304d
@jamieshark
Merge remote-tracking branch 'refs/remotes/origin/main' into css_modu…
4c7eae0 
…les_remove_flag_underlinepanels
@jamieshark
Move toggleSxComponent out of component render cycle.
1e8ed4b
@jamieshark
changeset.
b982ce6
@jamieshark
Simplify arguments for toggleSxComponent.
5db11c8
@jamieshark
Changeset.
47fe96c
@jamieshark
Merge branch 'main' into css_modules_remove_flag_underlinepanels
564ee3c
@jamieshark @github-actions
test(vrt): update snapshots
0bad285
@jamieshark
Merge branch 'css_modules_remove_flag_underlinepanels' into jshark/to…
c0b7eaa 
…ggle-component-fix
@jamieshark
Merge branch 'main' into jshark/toggle-component-fix
900b1b4
@jamieshark
Merge branch 'main' into jshark/toggle-component-fix
ca32eab
@jamieshark
Merge remote-tracking branch 'refs/remotes/origin/main' into jshark/t…
5833672 
…oggle-component-fix
@jamieshark
adjust arguments for function usage.
d9d4fb6
@jamieshark
Merge remote-tracking branch 'refs/remotes/origin/jshark/toggle-compo…
bb94f5f 
…nent-fix' into jshark/toggle-component-fix
@jonrohan
Remove the CSS modules feature flag from Text
af3c061
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Apr 3, 2025 •
edited
Loading

🦋 Changeset detected

Latest commit: 96276d1

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Apr 3, 2025
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Apr 3, 2025 •
edited
Loading

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 104.33 KB (-0.15% 🔽)
packages/react/dist/browser.umd.js 104.65 KB (-0.21% 🔽)

Base automatically changed from jshark/toggle-component-fix to main April 3, 2025 17:08
@github-actions github-actions bot temporarily deployed to storybook-preview-5868 April 3, 2025 17:08 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Apr 3, 2025
@github-actions github-actions bot requested a deployment to storybook-preview-5868 April 3, 2025 17:23 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-5868 April 3, 2025 17:37 Inactive
@github-actions github-actions bot temporarily deployed to storybook-preview-5868 April 10, 2025 17:39 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/372500

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Apr 10, 2025
@jonrohan jonrohan marked this pull request as ready for review April 10, 2025 20:36
@jonrohan jonrohan requested a review from a team as a code owner April 10, 2025 20:36
@jonrohan jonrohan added this pull request to the merge queue Apr 11, 2025
Merged via the queue into main with commit 7e6475d Apr 11, 2025
45 of 46 checks passed
@jonrohan jonrohan deleted the remove_css_module_flag_text branch April 11, 2025 16:45
@primer primer bot mentioned this pull request Apr 11, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshblack joshblack joshblack approved these changes

@hectahertz hectahertz Awaiting requested review from hectahertz hectahertz is a code owner automatically assigned from primer/engineer-reviewers

Assignees
No one assigned
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jonrohan @joshblack @jamieshark