Skip to content

chore(Stack): Remove the CSS modules feature flag from the Stack component #5870

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Apr 11, 2025

Conversation

jonrohan
Copy link
Member

@jonrohan jonrohan commented Apr 3, 2025

Closes https://github.com/github/primer/issues/4362

Changelog

New

Changed

Removed

Remove the CSS modules feature flag from the Stack component

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Apr 3, 2025

🦋 Changeset detected

Latest commit: 6d682ff

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Apr 3, 2025
Copy link
Contributor

github-actions bot commented Apr 3, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented Apr 3, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 103.73 KB (-0.73% 🔽)
packages/react/dist/browser.umd.js 104.21 KB (-0.63% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-5870 April 3, 2025 18:12 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Apr 3, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-5870 April 3, 2025 18:25 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/371243

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Apr 10, 2025
@jonrohan jonrohan marked this pull request as ready for review April 10, 2025 20:46
@jonrohan jonrohan requested a review from a team as a code owner April 10, 2025 20:46
@jonrohan jonrohan requested review from TylerJDev and joshblack April 10, 2025 20:46
@jonrohan jonrohan enabled auto-merge April 11, 2025 18:17
@jonrohan jonrohan added this pull request to the merge queue Apr 11, 2025
Merged via the queue into main with commit 7373295 Apr 11, 2025
46 of 47 checks passed
@jonrohan jonrohan deleted the remove_css_modules_feature_flag_stack branch April 11, 2025 18:31
@primer primer bot mentioned this pull request Apr 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants