Skip to content

fix(SelectPanel): use dvh units for full screen when available #5930

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 16, 2025

Conversation

francinelucca
Copy link
Member

@francinelucca francinelucca commented Apr 16, 2025

Fixes bug on iPhone were 100vh doesn't make all the content visible since it is rendering under the browser toolbar.

Changelog

New

  • CSS styles for using dvh units when supported in full screen

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Apr 16, 2025

🦋 Changeset detected

Latest commit: 6d33982

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Apr 16, 2025
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Apr 16, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented Apr 16, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 102.66 KB (0%)
packages/react/dist/browser.umd.js 102.96 KB (0%)

@github-actions github-actions bot requested a deployment to storybook-preview-5930 April 16, 2025 01:43 Abandoned
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/373340

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Apr 16, 2025
@francinelucca francinelucca marked this pull request as ready for review April 16, 2025 02:38
@francinelucca francinelucca requested a review from a team as a code owner April 16, 2025 02:38
@francinelucca francinelucca added this pull request to the merge queue Apr 16, 2025
Merged via the queue into main with commit 876b822 Apr 16, 2025
75 of 77 checks passed
@francinelucca francinelucca deleted the fix/selectpanel-mobile-full-height branch April 16, 2025 18:05
@primer primer bot mentioned this pull request Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants