refactor(Flash): update sx usage to CSS Modules #6007
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 85067e1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
staff
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
There was a problem hiding this comment.
Pull Request Overview
This PR refactors the Flash component to use CSS Modules instead of sx and styled-components, and updates the component implementation to leverage BoxWithFallback.
- Removed
styled-componentsandstyled-systemvariants - Added
Flash.module.csswith equivalent styles using CSS Modules and data attributes - Updated
Flash.tsxto render aBoxWithFallbackwith CSS class and data attributes
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 4 comments.
| File | Description |
|---|---|
| packages/react/src/Flash/Flash.tsx | Refactored component to use BoxWithFallback and CSS Modules, removed sx usage |
| packages/react/src/Flash/Flash.module.css | Added CSS Module definitions for variant and layout styles |
| .changeset/giant-bushes-matter.md | Minor release changeset noting the refactor |
size-limit report 📦
|
jonrohan
approved these changes
May 6, 2025
Merged
hectahertz
pushed a commit
that referenced
this pull request
May 20, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the
Flashcomponent from sx to CSS Modules. This change is not behind a feature flag since we're in the process of removing our GA flags.Changelog
New
Changed
sxusage of Flash internally to use CSS Modules insteadRemoved
Rollout strategy