chore(ActionList, NavList): Remove the CSS modules feature flag from ActionList and related components #6090
Conversation
🦋 Changeset detectedLatest commit: 7cae0b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
github-actions
bot
added
the
integration-tests: recommended
size-limit report 📦
|
| @@ -53,6 +53,9 @@ export type ActionListItemProps = { | |||
| */ | |||
| _PrivateItemWrapper?: React.FC<React.PropsWithChildren<MenuItemProps>> | |||
| className?: string | |||
| groupId?: string | |||
| renderItem?: (item: React.FC<React.PropsWithChildren<MenuItemProps>>) => React.ReactNode | |||
| handleAddItem?: (item: React.FC<React.PropsWithChildren<MenuItemProps>>) => void | |||
There was a problem hiding this comment.
Wanted to highlight this as something I'm unsure of? @joshblack I had to add these here because of the props I added on the item to satisfy the type errors
github-actions
bot
added
integration-tests: failing
…es_remove_flag/actionlist
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/380599 |
|
🟢 golden-jobs completed with status |
github-actions
bot
added
integration-tests: passing
|
Integration tests are now green, but the realease will need the changes in https://github.com/github/github/pull/381456 for them to pass. |
Closes https://github.com/github/primer/issues/5173
Changelog
New
Changed
Removed
Remove the CSS modules feature flag from ActionList and related components
Rollout strategy
Testing & Reviewing
Merge checklist