-
Notifications
You must be signed in to change notification settings - Fork 608
add new line of CSS to separate underline from hover event #6113
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add new line of CSS to separate underline from hover event #6113
Conversation
🦋 Changeset detectedLatest commit: 1942738 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/380074 |
🟢 golden-jobs completed with status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR addresses a hover gap issue in the UnderlineNav
component by preventing pointer events on the underline, ensuring the hover area doesn’t include the underline element.
- Added
pointer-events: none
to the underline pseudo-element to separate it from the hover area. - Included a changeset entry for a patch release.
Reviewed Changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
File | Description |
---|---|
packages/react/src/internal/components/UnderlineTabbedInterface.module.css | Added pointer-events: none to the underline to fix hover gap issue |
.changeset/clean-dolls-build.md | Added patch-level changeset with description of the CSS update |
Comments suppressed due to low confidence (1)
packages/react/src/internal/components/UnderlineTabbedInterface.module.css:108
- Add or update a visual regression or Storybook snapshot test for
UnderlineNav
to verify the hover gap fix and prevent future regressions.
pointer-events: none;
packages/react/src/internal/components/UnderlineTabbedInterface.module.css
Show resolved
Hide resolved
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
✨
Closes https://github.com/github/primer/issues/5176
Separates underline from tab hover event to address hover area gap issue.
Loom: updated behavior
Changelog
New
Added a new line of CSS to separate the
UnderlineNav
underline from the hover areaChanged
Changed hover event on
UnderlineNav
componentRemoved
N/A
Rollout strategy
Testing & Reviewing
This change can be seen by looking at
UnderlineNav
in Storybook previewMerge checklist