Skip to content

add new line of CSS to separate underline from hover event #6113

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 4 commits into from
May 29, 2025

Conversation

llastflowers
Copy link
Contributor

@llastflowers llastflowers commented May 22, 2025

Closes https://github.com/github/primer/issues/5176

Separates underline from tab hover event to address hover area gap issue.

Loom: updated behavior

Changelog

New

Added a new line of CSS to separate the UnderlineNav underline from the hover area

Changed

Changed hover event on UnderlineNav component

Removed

N/A

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

This change can be seen by looking at UnderlineNav in Storybook preview

Merge checklist

Copy link

changeset-bot bot commented May 22, 2025

🦋 Changeset detected

Latest commit: 1942738

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@primer/react Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label May 22, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

github-actions bot commented May 22, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 94.34 KB (0%)
packages/react/dist/browser.umd.js 94.5 KB (0%)

@github-actions github-actions bot temporarily deployed to storybook-preview-6113 May 22, 2025 20:39 Inactive
@francinelucca francinelucca added skip changeset This change does not need a changelog and removed skip changeset This change does not need a changelog labels May 27, 2025
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/380074

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels May 27, 2025
@llastflowers llastflowers marked this pull request as ready for review May 27, 2025 21:40
@Copilot Copilot AI review requested due to automatic review settings May 27, 2025 21:40
@llastflowers llastflowers requested a review from a team as a code owner May 27, 2025 21:40
@llastflowers llastflowers requested a review from hectahertz May 27, 2025 21:40
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR addresses a hover gap issue in the UnderlineNav component by preventing pointer events on the underline, ensuring the hover area doesn’t include the underline element.

  • Added pointer-events: none to the underline pseudo-element to separate it from the hover area.
  • Included a changeset entry for a patch release.

Reviewed Changes

Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.

File Description
packages/react/src/internal/components/UnderlineTabbedInterface.module.css Added pointer-events: none to the underline to fix hover gap issue
.changeset/clean-dolls-build.md Added patch-level changeset with description of the CSS update
Comments suppressed due to low confidence (1)

packages/react/src/internal/components/UnderlineTabbedInterface.module.css:108

  • Add or update a visual regression or Storybook snapshot test for UnderlineNav to verify the hover gap fix and prevent future regressions.
pointer-events: none;

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label May 27, 2025
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

Copy link
Member

@francinelucca francinelucca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@llastflowers llastflowers added this pull request to the merge queue May 29, 2025
Merged via the queue into main with commit 96c4b48 May 29, 2025
36 checks passed
@llastflowers llastflowers deleted the llastflowers/5176/fix-UnderlineNav-hover-issue branch May 29, 2025 15:46
@primer primer bot mentioned this pull request May 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants