Skip to content

ActionList: Add new prop disableFocusZone #6116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

TylerJDev
Copy link
Member

@TylerJDev TylerJDev commented May 23, 2025

Closes https://github.com/github/primer/issues/5227

Changelog

New

  • Adds new prop disableFocusZone which allows consumers to disable the focusZone that is applied to the ActionList component

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented May 23, 2025

⚠️ No Changeset found

Latest commit: d72b410

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels May 23, 2025
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 94.36 KB (+0.02% 🔺)
packages/react/dist/browser.umd.js 94.43 KB (-0.08% 🔽)

showDividers = false,
role,
sx: sxProp = defaultSxProp,
disableFocusZone = false,
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We could instead add a prop named focusZoneSettings, which allows consumers to customize the focus zone. This would work much like how it does in AnchoredOverlay.

This might not be needed now, but gives consumers more flexibility with the component, and removes the need for the disableFocusZone boolean prop.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant