Skip to content

Conversation

@llastflowers
Copy link
Contributor

Closes https://github.com/github/primer/issues/4829

Changelog

Removed

Removed anything associated with styled-components/sx from SplitPageLayout including any references in docs and tests

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

There is currently no sx usage with this component in dotcom, and this will be confirmed again before merging.

Testing & Reviewing

Merge checklist

@changeset-bot
Copy link

changeset-bot bot commented Aug 15, 2025

🦋 Changeset detected

Latest commit: 94b2f8e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 3 packages
Name Type
@primer/react Major
@primer/mcp Patch
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Aug 15, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@llastflowers llastflowers self-assigned this Aug 15, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Aug 15, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 90.28 KB (0%)
packages/react/dist/browser.umd.js 90.45 KB (0%)

@github-actions github-actions bot requested a deployment to storybook-preview-6613 August 15, 2025 19:02 Abandoned
@github-actions github-actions bot temporarily deployed to storybook-preview-6613 August 15, 2025 19:12 Inactive
@primer-integration
Copy link

👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/396923

@primer-integration
Copy link

🟢 golden-jobs completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Aug 15, 2025
@llastflowers llastflowers marked this pull request as ready for review August 15, 2025 20:38
Copilot AI review requested due to automatic review settings August 15, 2025 20:38
@llastflowers llastflowers requested a review from a team as a code owner August 15, 2025 20:38
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes styled-components/sx support from the SplitPageLayout component as part of a migration away from styled-components. The change eliminates sx prop support from the main component and all its subcomponents.

  • Removes SxProp interface usage from SplitPageLayoutProps type definition
  • Updates component documentation to remove deprecated sx prop references
  • Removes sx usage from Storybook stories

Reviewed Changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.

File Description
packages/react/src/SplitPageLayout/SplitPageLayout.tsx Removes SxProp import and sx support from main component type
packages/react/src/SplitPageLayout/SplitPageLayout.stories.tsx Removes sx prop usage from Storybook template
packages/react/src/SplitPageLayout/SplitPageLayout.docs.json Removes sx prop documentation from all subcomponents
.changeset/young-timers-accept.md Adds changeset entry for major version bump

You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.

@llastflowers llastflowers requested a review from joshblack August 15, 2025 20:38
@llastflowers llastflowers enabled auto-merge August 21, 2025 16:53
@llastflowers llastflowers disabled auto-merge August 21, 2025 16:59
@llastflowers llastflowers added this pull request to the merge queue Aug 22, 2025
Merged via the queue into main with commit 3ab94c5 Aug 22, 2025
43 checks passed
@llastflowers llastflowers deleted the llastflowers/4829/no-sx-SplitPageLayout branch August 22, 2025 17:09
@primer primer bot mentioned this pull request Aug 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants