-
Notifications
You must be signed in to change notification settings - Fork 646
Remove sx support from SplitPageLayout component #6613
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: 94b2f8e The changes in this PR will be included in the next version bump. This PR includes changesets to release 3 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/396923 |
|
🟢 golden-jobs completed with status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes styled-components/sx support from the SplitPageLayout component as part of a migration away from styled-components. The change eliminates sx prop support from the main component and all its subcomponents.
- Removes SxProp interface usage from SplitPageLayoutProps type definition
- Updates component documentation to remove deprecated sx prop references
- Removes sx usage from Storybook stories
Reviewed Changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
| packages/react/src/SplitPageLayout/SplitPageLayout.tsx | Removes SxProp import and sx support from main component type |
| packages/react/src/SplitPageLayout/SplitPageLayout.stories.tsx | Removes sx prop usage from Storybook template |
| packages/react/src/SplitPageLayout/SplitPageLayout.docs.json | Removes sx prop documentation from all subcomponents |
| .changeset/young-timers-accept.md | Adds changeset entry for major version bump |
You can also share your feedback on Copilot code review for a chance to win a $100 gift card. Take the survey.
Closes https://github.com/github/primer/issues/4829
Changelog
Removed
Removed anything associated with styled-components/sx from SplitPageLayout including any references in docs and tests
Rollout strategy
There is currently no
sxusage with this component in dotcom, and this will be confirmed again before merging.Testing & Reviewing
Merge checklist