-
Notifications
You must be signed in to change notification settings - Fork 646
Remove sx props and Box from Truncate
#6632
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🦋 Changeset detectedLatest commit: a5bd7a9 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
|
👋 Hi from github/github! Your integration PR is ready: https://github.com/github/github/pull/397797 |
|
🔴 golden-jobs completed with status |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR migrates the Truncate component from using BoxWithFallback and sx props to CSS modules as part of the design system modernization effort. This is a breaking change that removes styled-system dependencies.
- Removes
sxprop support andMaxWidthPropsfromTruncatecomponent - Replaces
BoxWithFallbackwith direct component rendering using polymorphicasprop - Creates a styled wrapper in
@primer/styled-reactpackage to maintain backward compatibility
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 1 comment.
Show a summary per file
| File | Description |
|---|---|
packages/react/src/Truncate/Truncate.tsx |
Main component migration removing sx props and BoxWithFallback |
packages/styled-react/src/index.ts |
Adds styled wrapper for Truncate to maintain backward compatibility |
packages/react/src/ActionList/Description.tsx |
Removes sx prop usage from Truncate component |
packages/react/src/Truncate/Truncate.stories.tsx |
Removes sx prop from Storybook controls |
packages/react/src/Truncate/Truncate.docs.json |
Updates documentation to reflect API changes |
packages/styled-react/src/__tests__/__snapshots__/exports.test.ts.snap |
Updates test snapshot for export changes |
.changeset/lucky-facts-obey.md |
Changeset documenting the breaking change |
|
integration checks manually ran here: https://github.com/github/github-ui/pull/1180 |
Migrates the
Truncatecomponent away fromBoxWithFallbackcomponents andsxprop support to use CSS modules, Closes #4822Truncatewith sx props includinggithub/github-ui.Rollout strategy