Skip to content

Conversation

@llastflowers
Copy link
Contributor

@llastflowers llastflowers commented Aug 22, 2025

Closes https://github.com/github/primer/issues/5748

Current sx usage: 0

✅ Don't need to separately update github-ui components to use @primer/styled-react

Changelog

Removed

Remove support for sx from the AvatarStack component, and associated stories, docs, and tests

Rollout strategy

  • Major release; if selected, include a written rollout or migration plan

This component currently has 0 sx usage in dotcom, and therefore does not need the @primer/styled-react wrapper. this will be confirmed again before merging.

Merge checklist

@llastflowers llastflowers self-assigned this Aug 22, 2025
@changeset-bot
Copy link

changeset-bot bot commented Aug 22, 2025

🦋 Changeset detected

Latest commit: 15a017e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Aug 22, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 22, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 89.9 KB (-0.04% 🔽)
packages/react/dist/browser.umd.js 89.98 KB (-0.15% 🔽)

@github-actions github-actions bot temporarily deployed to storybook-preview-6652 August 22, 2025 20:53 Inactive
@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Aug 22, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6652 August 22, 2025 21:47 Inactive
@primer primer deleted a comment from primer-integration bot Aug 26, 2025
@primer primer deleted a comment from primer-integration bot Aug 26, 2025
@llastflowers llastflowers added integration-tests: skipped manually Changes in this PR do not require an integration test and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Aug 26, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6652 August 26, 2025 17:10 Inactive
@llastflowers llastflowers marked this pull request as ready for review August 27, 2025 18:35
Copilot AI review requested due to automatic review settings August 27, 2025 18:35
@llastflowers llastflowers requested a review from a team as a code owner August 27, 2025 18:35
@llastflowers llastflowers requested a review from pksjce August 27, 2025 18:35
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated sx prop support from the AvatarStack component as part of migrating away from styled-components. The change is part of a larger effort to modernize the component API and eliminate dependencies on the legacy styling system.

Key changes:

  • Removed sx prop from AvatarStack component interface and implementation
  • Cleaned up related Storybook stories, documentation, and tests
  • Added changeset for major version release

Reviewed Changes

Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/react/src/AvatarStack/AvatarStack.tsx Removed SxProp import, sx prop from type definition and component destructuring
packages/react/src/AvatarStack/AvatarStack.stories.tsx Removed sx prop configuration from Storybook argTypes
packages/react/src/AvatarStack/AvatarStack.docs.json Removed sx prop from component documentation
packages/react/src/AvatarStack/AvatarStack.dev.stories.tsx Removed SxProp story example
e2e/components/AvatarStack.test.ts Removed SX Prop test case from e2e test suite
.changeset/few-mails-sing.md Added changeset entry for major version bump

@llastflowers llastflowers added this pull request to the merge queue Sep 2, 2025
Merged via the queue into main with commit c6d923f Sep 2, 2025
43 checks passed
@llastflowers llastflowers deleted the llastflowers/5748/no-sx-AvatarStack branch September 2, 2025 17:19
@primer primer bot mentioned this pull request Sep 2, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: skipped manually Changes in this PR do not require an integration test

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants