- 
                Notifications
    
You must be signed in to change notification settings  - Fork 640
 
          Remove support for sx from AvatarStack component
          #6652
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
          🦋 Changeset detectedLatest commit: 15a017e The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
 Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR  | 
    
| 
          
 👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!  | 
    
          size-limit report 📦
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the deprecated sx prop support from the AvatarStack component as part of migrating away from styled-components. The change is part of a larger effort to modernize the component API and eliminate dependencies on the legacy styling system.
Key changes:
- Removed 
sxprop from AvatarStack component interface and implementation - Cleaned up related Storybook stories, documentation, and tests
 - Added changeset for major version release
 
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description | 
|---|---|
packages/react/src/AvatarStack/AvatarStack.tsx | 
Removed SxProp import, sx prop from type definition and component destructuring | 
packages/react/src/AvatarStack/AvatarStack.stories.tsx | 
Removed sx prop configuration from Storybook argTypes | 
packages/react/src/AvatarStack/AvatarStack.docs.json | 
Removed sx prop from component documentation | 
packages/react/src/AvatarStack/AvatarStack.dev.stories.tsx | 
Removed SxProp story example | 
e2e/components/AvatarStack.test.ts | 
Removed SX Prop test case from e2e test suite | 
.changeset/few-mails-sing.md | 
Added changeset entry for major version bump | 
Closes https://github.com/github/primer/issues/5748
Current
sxusage: 0✅ Don't need to separately update github-ui components to use @primer/styled-react
Changelog
Removed
Remove support for
sxfrom theAvatarStackcomponent, and associated stories, docs, and testsRollout strategy
This component currently has 0
sxusage in dotcom, and therefore does not need the @primer/styled-react wrapper. this will be confirmed again before merging.Merge checklist