Skip to content

Conversation

@liuliu-dev
Copy link
Contributor

@liuliu-dev liuliu-dev commented Aug 25, 2025

Closes #5770

UnderlineNav usage

Changelog

Removed

Removed sx props and Box from UnderlineNav.

Rollout strategy

  • Major release; if selected, include a written rollout or migration plan

@changeset-bot
Copy link

changeset-bot bot commented Aug 25, 2025

🦋 Changeset detected

Latest commit: d59c187

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Aug 25, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Aug 25, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 89.8 KB (-0.06% 🔽)
packages/react/dist/browser.umd.js 90.05 KB (+0.07% 🔺)

@github-actions github-actions bot temporarily deployed to storybook-preview-6668 August 26, 2025 22:58 Inactive
@liuliu-dev liuliu-dev marked this pull request as ready for review August 26, 2025 22:58
Copilot AI review requested due to automatic review settings August 26, 2025 22:58
@liuliu-dev liuliu-dev requested a review from a team as a code owner August 26, 2025 22:58
@liuliu-dev liuliu-dev requested a review from TylerJDev August 26, 2025 22:58
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the deprecated sx prop and Box component usage from the UnderlineNav component as part of a major release. The changes replace styled-system functionality with CSS modules and native HTML elements for better performance and maintainability.

Key Changes

  • Removed sx prop support from both UnderlineNav and UnderlineNavItem components
  • Replaced Box components with native HTML elements (li, div, span)
  • Migrated inline styles to CSS modules for better maintainability

Reviewed Changes

Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/react/src/UnderlineNav/styles.ts Changed marginRight from theme unit to explicit pixel value
packages/react/src/UnderlineNav/UnderlineNavItem.tsx Removed sx prop, Box import, replaced Box with li element and CSS module
packages/react/src/UnderlineNav/UnderlineNavItem.module.css Added CSS module for UnderlineNavItem styling
packages/react/src/UnderlineNav/UnderlineNav.tsx Removed sx prop, Box imports, replaced Box elements with native HTML
packages/react/src/UnderlineNav/UnderlineNav.module.css Added CSS module for menu item content styling
packages/react/src/UnderlineNav/UnderlineNav.docs.json Removed sx prop from documentation
.changeset/hot-mirrors-feel.md Added changeset for major version bump

@liuliu-dev liuliu-dev disabled auto-merge September 22, 2025 17:32
@github-merge-queue github-merge-queue bot removed this pull request from the merge queue due to a conflict with the base branch Sep 22, 2025
@github-actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 22, 2025
@github-actions github-actions bot temporarily deployed to storybook-preview-6668 September 22, 2025 17:56 Inactive
@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 22, 2025
@github-actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 22, 2025
@github-actions github-actions bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Sep 22, 2025
@github-actions
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-6668 September 22, 2025 18:04 Inactive
@liuliu-dev liuliu-dev added this pull request to the merge queue Sep 22, 2025
Merged via the queue into main with commit acb6233 Sep 22, 2025
42 checks passed
@liuliu-dev liuliu-dev deleted the liuliu/migrate-underlinenav branch September 22, 2025 18:23
@primer primer bot mentioned this pull request Sep 22, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants