-
Notifications
You must be signed in to change notification settings - Fork 645
Revert "Remove sx props and BoxWithFallback from RadioGroup (#6642)" #6684
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
This reverts commit 03c635c.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR reverts a previous change that removed sx props and BoxWithFallback from RadioGroup components. The revert restores these features while the team addresses downstream integration issues.
- Restores sx prop support to RadioGroup and related components
- Re-adds BoxWithFallback component usage in CheckboxOrRadioGroup
- Updates styled-react package to include RadioGroup export
Reviewed Changes
Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/styled-react/src/index.ts | Re-adds RadioGroup import and export to styled-react package |
| packages/styled-react/src/tests/snapshots/exports.test.ts.snap | Updates test snapshot to include RadioGroup in exports |
| packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroupValidation.tsx | Restores sx prop support to validation component |
| packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroupLabel.tsx | Restores sx prop support to label component |
| packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroupCaption.tsx | Restores sx prop support to caption component |
| packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroup.tsx | Re-adds BoxWithFallback usage and sx prop support |
| packages/react/src/RadioGroup/RadioGroup.tsx | Restores sx prop type to RadioGroup component |
| packages/react/src/RadioGroup/RadioGroup.stories.tsx | Excludes sx from Storybook controls |
| packages/react/src/CheckboxGroup/CheckboxGroup.dev.stories.tsx | Converts CSS module usage to sx props |
| packages/react/src/CheckboxGroup/CheckboxGroup.dev.stories.module.css | Removes CSS module file |
| packages/react/src/Banner/Banner.examples.stories.tsx | Converts CSS module usage to sx props |
| packages/react/src/Banner/Banner.examples.stories.module.css | Removes CSS module file |
| .changeset/quick-bats-remain.md | Removes changeset file for the reverted change |
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
This reverts commit 03c635c.
We're running into some issues integrating this downstream so am reverting while we figure it out 👀