Skip to content

Conversation

@joshblack
Copy link
Member

This reverts commit 03c635c.

We're running into some issues integrating this downstream so am reverting while we figure it out 👀

Copilot AI review requested due to automatic review settings August 27, 2025 21:24
@joshblack joshblack requested a review from a team as a code owner August 27, 2025 21:24
@joshblack joshblack requested a review from TylerJDev August 27, 2025 21:24
@changeset-bot
Copy link

changeset-bot bot commented Aug 27, 2025

⚠️ No Changeset found

Latest commit: 4db1212

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions github-actions bot added the staff Author is a staff member label Aug 27, 2025
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR reverts a previous change that removed sx props and BoxWithFallback from RadioGroup components. The revert restores these features while the team addresses downstream integration issues.

  • Restores sx prop support to RadioGroup and related components
  • Re-adds BoxWithFallback component usage in CheckboxOrRadioGroup
  • Updates styled-react package to include RadioGroup export

Reviewed Changes

Copilot reviewed 13 out of 13 changed files in this pull request and generated no comments.

Show a summary per file
File Description
packages/styled-react/src/index.ts Re-adds RadioGroup import and export to styled-react package
packages/styled-react/src/tests/snapshots/exports.test.ts.snap Updates test snapshot to include RadioGroup in exports
packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroupValidation.tsx Restores sx prop support to validation component
packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroupLabel.tsx Restores sx prop support to label component
packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroupCaption.tsx Restores sx prop support to caption component
packages/react/src/internal/components/CheckboxOrRadioGroup/CheckboxOrRadioGroup.tsx Re-adds BoxWithFallback usage and sx prop support
packages/react/src/RadioGroup/RadioGroup.tsx Restores sx prop type to RadioGroup component
packages/react/src/RadioGroup/RadioGroup.stories.tsx Excludes sx from Storybook controls
packages/react/src/CheckboxGroup/CheckboxGroup.dev.stories.tsx Converts CSS module usage to sx props
packages/react/src/CheckboxGroup/CheckboxGroup.dev.stories.module.css Removes CSS module file
packages/react/src/Banner/Banner.examples.stories.tsx Converts CSS module usage to sx props
packages/react/src/Banner/Banner.examples.stories.module.css Removes CSS module file
.changeset/quick-bats-remain.md Removes changeset file for the reverted change

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Aug 27, 2025
@github-actions
Copy link
Contributor

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot temporarily deployed to storybook-preview-6684 August 27, 2025 21:33 Inactive
@github-actions
Copy link
Contributor

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 89.94 KB (+0.01% 🔺)
packages/react/dist/browser.umd.js 90.11 KB (+0.01% 🔺)

@joshblack joshblack merged commit 9acebe1 into main Aug 27, 2025
43 checks passed
@joshblack joshblack deleted the revert/remove-sx-from-radio-group branch August 27, 2025 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants