- 
                Notifications
    
You must be signed in to change notification settings  - Fork 640
 
remove sx from RadioGroup and Truncate #6685
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
remove sx from RadioGroup and Truncate #6685
Conversation
          🦋 Changeset detectedLatest commit: 90be68b The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
 Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR  | 
    
| 
          
 👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!  | 
    
          size-limit report 📦
  | 
    
…-RadioGroup-and-Truncate
…-RadioGroup-and-Truncate
| 
           Uh oh! @liuliu-dev, at least one image you shared is missing helpful alt text. Check your pull request body to fix the following violations: 
 Alt text is an invisible description that helps screen readers describe images to blind or low-vision users. If you are using markdown to display images, add your alt text inside the brackets of the markdown image. Learn more about alt text at Basic writing and formatting syntax: images on GitHub Docs. 
  | 
    
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the sx prop support from the RadioGroup and Truncate components as part of migrating away from styled-components to CSS modules. The changes ensure backward compatibility by maintaining sx support in the styled-react package while removing it from the core components.
- Removes 
sxprop fromRadioGroupandTruncatecomponents in the main package - Adds wrapper components in 
styled-reactpackage to maintain backward compatibility - Migrates 
TruncatefromBoxWithFallbackto native React components with CSS modules 
Reviewed Changes
Copilot reviewed 11 out of 11 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description | 
|---|---|
| packages/styled-react/src/index.tsx | Adds wrapper components for RadioGroup and Truncate that restore sx prop support for backward compatibility | 
| packages/react/src/index.ts | Exports RadioGroupProps type for external usage | 
| packages/react/src/Truncate/Truncate.tsx | Removes sx prop and BoxWithFallback dependency, migrates to CSS modules | 
| packages/react/src/RadioGroup/RadioGroup.tsx | Removes sx prop from RadioGroupProps type definition | 
| packages/react/src/Banner/Banner.examples.stories.tsx | Replaces sx prop usage with CSS module class | 
| packages/react/src/ActionList/Description.tsx | Removes sx prop usage from Truncate component | 
| 
          
 👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!  | 
    
| 
          
 👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!  | 
    
| 
          
 👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/3014  | 
    
| 
          
 🟢 ci completed with status   | 
    
Removes support for the
sxprop from theRadioGroupcomponentSxPropand replacesxin Banner.examples.stories that usesRadioGroupTruncatecomponent away fromBoxWithFallbackcomponents andsxprop support to use CSS modulesNote:
sxprops withRadioGroup.Truncatewith sx props includinggithub/github-ui, need to update the import ingithub/github-ui, wait until this change is in to update the export pattens.