Remove sx prop support from the Token component
#6690
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: dd53474 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
added
the
integration-tests: recommended
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
github-actions
bot
requested a deployment
to
storybook-preview-6690
…b.com/primer/react into liuliu/remove-sx-from-token-component
github-actions
bot
added
integration-tests: failing
github-actions
bot
removed
the
integration-tests: recommended
github-actions
bot
added
integration-tests: failing
packages/react/src/TextInputWithTokens/__snapshots__/TextInputWithTokens.test.tsx.snap
Show resolved
Hide resolved
francinelucca
approved these changes
Sep 26, 2025
liuliu-dev
changed the title
Token component Token component
liuliu-dev
changed the title
Token component Token component
github-actions
bot
added
the
integration-tests: recommended
|
👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! |
github-actions
bot
added
integration-tests: failing
|
👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/3583 |
|
🟢 ci completed with status |
github-actions
bot
added
integration-tests: passing
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Wait until this PR is merged in
github-ui: https://github.com/github/github-ui/pull/3366Closes #5813
Need to be careful about the
PolymorphicForwardRefComponenttype change.Need to do changes in
github-uisince it's still usingTokencomponent withsx, tracking here: https://github.com/github/primer/issues/5827Changelog
Removed
Rollout strategy