Skip to content

Conversation

@TylerJDev
Copy link
Member

Closes #6434

Removes skipped tests in ActionMenu.

Changelog

Removed

  • Tests in ActionMenu

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copilot AI review requested due to automatic review settings September 3, 2025 15:31
@TylerJDev TylerJDev requested a review from a team as a code owner September 3, 2025 15:31
@TylerJDev TylerJDev requested a review from jonrohan September 3, 2025 15:31
@changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2025

⚠️ No Changeset found

Latest commit: 3f523da

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@TylerJDev TylerJDev added the skip changeset This change does not need a changelog label Sep 3, 2025
@github-actions github-actions bot added staff Author is a staff member integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Sep 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 89.83 KB (0%)
packages/react/dist/browser.umd.js 90 KB (0%)

Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes two skipped test cases from the ActionMenu component test suite that were previously failing due to focus trap issues. The tests were marked as TODO items with references to GitHub issue #6434.

  • Removes two it.skip test cases related to focus management in ActionMenu
  • Eliminates associated TODO comments that referenced the GitHub issue
Comments suppressed due to low confidence (1)

packages/react/src/ActionMenu/ActionMenu.test.tsx:1

  • The removal of the two skipped focus management tests reduces test coverage for critical accessibility behavior. The remaining test at line 228 validates keyboard shortcuts but doesn't cover the focus management scenarios that were previously tested (button focus retention after click and arrow key navigation). Consider implementing working versions of these tests or documenting why this behavior is no longer tested.
import {describe, expect, it, vi} from 'vitest'

@TylerJDev TylerJDev added this pull request to the merge queue Sep 3, 2025
Merged via the queue into main with commit 116ec5f Sep 3, 2025
49 of 50 checks passed
@TylerJDev TylerJDev deleted the remove-skipped-test-action-menu branch September 3, 2025 16:19
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm skip changeset This change does not need a changelog staff Author is a staff member

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unexpected ActionMenu focus handling

3 participants