-
Notifications
You must be signed in to change notification settings - Fork 645
Remove skipped tests in ActionMenu
#6711
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes two skipped test cases from the ActionMenu component test suite that were previously failing due to focus trap issues. The tests were marked as TODO items with references to GitHub issue #6434.
- Removes two
it.skiptest cases related to focus management in ActionMenu - Eliminates associated TODO comments that referenced the GitHub issue
Comments suppressed due to low confidence (1)
packages/react/src/ActionMenu/ActionMenu.test.tsx:1
- The removal of the two skipped focus management tests reduces test coverage for critical accessibility behavior. The remaining test at line 228 validates keyboard shortcuts but doesn't cover the focus management scenarios that were previously tested (button focus retention after click and arrow key navigation). Consider implementing working versions of these tests or documenting why this behavior is no longer tested.
import {describe, expect, it, vi} from 'vitest'
Closes #6434
Removes skipped tests in
ActionMenu.Changelog
Removed
ActionMenuRollout strategy
Testing & Reviewing
Merge checklist