Skip to content

Conversation

@liuliu-dev
Copy link
Contributor

Remove sx from the SelectPanel component
Closes #5826

sx usage: 0

Rollout strategy

  • Major release; if selected, include a written rollout or migration plan

@changeset-bot
Copy link

changeset-bot bot commented Sep 3, 2025

🦋 Changeset detected

Latest commit: 595d693

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 3, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 3, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 87.92 KB (+0.01% 🔺)
packages/react/dist/browser.umd.js 88.2 KB (+0.15% 🔺)

@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/2021

@primer-integration
Copy link

🟢 ci completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Sep 8, 2025
@liuliu-dev liuliu-dev marked this pull request as ready for review September 8, 2025 22:26
Copilot AI review requested due to automatic review settings September 8, 2025 22:26
@liuliu-dev liuliu-dev requested a review from a team as a code owner September 8, 2025 22:26
@liuliu-dev liuliu-dev requested a review from pksjce September 8, 2025 22:26
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the sx prop from the SelectPanel component as part of the ongoing migration away from styled-components to CSS modules. The change replaces the inline sx styling with a dedicated CSS class for the text input margin and removes the sx prop from the component interface and FilteredActionList.

Key Changes

  • Removed sx prop from SelectPanel component interface
  • Replaced inline sx styling for TextInput with CSS module class
  • Added new CSS class .TextInput with margin styling in SelectPanel.module.css

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/react/src/SelectPanel/SelectPanel.tsx Removed sx prop from component interface and replaced inline styling with CSS class
packages/react/src/SelectPanel/SelectPanel.module.css Added .TextInput CSS class with margin styling
.changeset/lemon-jokes-camp.md Added changeset documenting the major breaking change

Comment on lines -864 to -865
// inheriting height and maxHeight ensures that the FilteredActionList is never taller
// than the Overlay (which would break scrolling the items)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe we should keep this comment, but move it near the relevant code in the css module?

@github-actions
Copy link
Contributor

github-actions bot commented Sep 8, 2025

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 8, 2025
@liuliu-dev liuliu-dev added this pull request to the merge queue Sep 8, 2025
Merged via the queue into main with commit e177d55 Sep 8, 2025
43 checks passed
@liuliu-dev liuliu-dev deleted the liuliu/remove-sx-from-selectpanel branch September 8, 2025 23:13
@primer primer bot mentioned this pull request Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants