- 
                Notifications
    You must be signed in to change notification settings 
- Fork 640
Remove sx from the SelectPanel component #6716
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 🦋 Changeset detectedLatest commit: 595d693 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
 Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR | 
| 👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! | 
| size-limit report 📦
 | 
| 👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/2021 | 
| 🟢 ci completed with status  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the sx prop from the SelectPanel component as part of the ongoing migration away from styled-components to CSS modules. The change replaces the inline sx styling with a dedicated CSS class for the text input margin and removes the sx prop from the component interface and FilteredActionList.
Key Changes
- Removed sxprop from SelectPanel component interface
- Replaced inline sxstyling for TextInput with CSS module class
- Added new CSS class .TextInputwith margin styling in SelectPanel.module.css
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description | 
|---|---|
| packages/react/src/SelectPanel/SelectPanel.tsx | Removed sxprop from component interface and replaced inline styling with CSS class | 
| packages/react/src/SelectPanel/SelectPanel.module.css | Added .TextInputCSS class with margin styling | 
| .changeset/lemon-jokes-camp.md | Added changeset documenting the major breaking change | 
| // inheriting height and maxHeight ensures that the FilteredActionList is never taller | ||
| // than the Overlay (which would break scrolling the items) | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe we should keep this comment, but move it near the relevant code in the css module?
| 👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks! | 
Remove
sxfrom theSelectPanelcomponentCloses #5826
sx usage: 0
Rollout strategy