Skip to content

Conversation

@liuliu-dev
Copy link
Contributor

@liuliu-dev liuliu-dev commented Sep 5, 2025

Closes #5833

Changelog

Removed

Removed sx from Select.

Rollout strategy

  • Major release; if selected, include a written rollout or migration plan

@changeset-bot
Copy link

changeset-bot bot commented Sep 5, 2025

🦋 Changeset detected

Latest commit: 0cb9504

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 5, 2025
@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions
Copy link
Contributor

github-actions bot commented Sep 5, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 87.92 KB (-0.07% 🔽)
packages/react/dist/browser.umd.js 88.07 KB (-0.01% 🔽)

@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/1978

@github-actions github-actions bot added integration-tests: failing Changes in this PR cause breaking changes in gh/gh and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Sep 8, 2025
@primer-integration
Copy link

🟢 ci completed with status success.

@github-actions github-actions bot added integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh and removed integration-tests: failing Changes in this PR cause breaking changes in gh/gh labels Sep 8, 2025
@liuliu-dev liuliu-dev marked this pull request as ready for review September 8, 2025 21:21
Copilot AI review requested due to automatic review settings September 8, 2025 21:21
@liuliu-dev liuliu-dev requested a review from a team as a code owner September 8, 2025 21:21
@liuliu-dev liuliu-dev requested a review from joshblack September 8, 2025 21:21
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR removes the sx prop from the Select component as part of a breaking change in a major version release. The change eliminates styled-components API support in favor of CSS Modules approach.

  • Remove sx prop from SelectProps type definition and component implementation
  • Update Storybook configuration to exclude the removed prop from controls
  • Add changeset documentation for the breaking change

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.

File Description
packages/react/src/Select/Select.tsx Removes sx prop from destructuring and TextInputWrapper component usage
packages/react/src/Select/Select.stories.tsx Updates Storybook controls exclude list to remove sx
.changeset/new-shrimps-appear.md Documents the breaking change for release notes

@liuliu-dev liuliu-dev added this pull request to the merge queue Sep 8, 2025
Merged via the queue into main with commit 2d01fc4 Sep 8, 2025
44 checks passed
@liuliu-dev liuliu-dev deleted the liuliu/remove-sx-from-select branch September 8, 2025 22:54
@primer primer bot mentioned this pull request Sep 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants