- 
                Notifications
    You must be signed in to change notification settings 
- Fork 640
          Remove sx rom the Select component
          #6737
        
          New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
| 🦋 Changeset detectedLatest commit: 0cb9504 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
 Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR | 
| 👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! | 
| size-limit report 📦
 | 
| 👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/1978 | 
| 🟢 ci completed with status  | 
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Pull Request Overview
This PR removes the sx prop from the Select component as part of a breaking change in a major version release. The change eliminates styled-components API support in favor of CSS Modules approach.
- Remove sxprop fromSelectPropstype definition and component implementation
- Update Storybook configuration to exclude the removed prop from controls
- Add changeset documentation for the breaking change
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated no comments.
| File | Description | 
|---|---|
| packages/react/src/Select/Select.tsx | Removes sxprop from destructuring and TextInputWrapper component usage | 
| packages/react/src/Select/Select.stories.tsx | Updates Storybook controls exclude list to remove sx | 
| .changeset/new-shrimps-appear.md | Documents the breaking change for release notes | 
Closes #5833
tracking here: https://github.com/github/primer/issues/5827
Changelog
Removed
Removed
sxfromSelect.Rollout strategy