v38: Make sure Banner is exported from main and experimental #6750
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: b2e55b8 The changes in this PR will be included in the next version bump. This PR includes changesets to release 2 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
There was a problem hiding this comment.
Pull Request Overview
This PR moves the Banner component from experimental to the main exports of @primer/react, making it available for general use as a replacement for the Flash component.
- Move Banner component and types from experimental to main package exports
- Update all import paths from experimental to direct Banner imports
- Update Storybook story titles to reflect the component's new non-experimental status
Reviewed Changes
Copilot reviewed 9 out of 9 changed files in this pull request and generated no comments.
Show a summary per file
| File | Description |
|---|---|
| packages/react/src/index.ts | Add Banner exports to main package exports |
| packages/react/src/tests/snapshots/exports.test.ts.snap | Update export snapshots removing Banner from experimental and adding to main |
| packages/react/src/Button/Button.examples.stories.tsx | Update import path from experimental to direct Banner import |
| packages/react/src/Banner/Banner.stories.tsx | Update story title from Experimental/Components to Components |
| packages/react/src/Banner/Banner.figma.tsx | Update import path from experimental to main package |
| packages/react/src/Banner/Banner.features.stories.tsx | Update story title from Experimental/Components to Components |
| packages/react/src/Banner/Banner.examples.stories.tsx | Update story title from Experimental/Components to Components |
| packages/react/src/Banner/Banner.docs.json | Update importPath and story IDs to reflect non-experimental status |
| e2e/components/Banner.test.ts | Update story IDs in tests to match new non-experimental paths |
github-actions
bot
added
the
integration-tests: recommended
|
👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks! |
size-limit report 📦
|
joshblack
approved these changes
Sep 8, 2025
francinelucca
approved these changes
Sep 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/github/primer/issues/5628
In this PR, we will move Banner component to the main export. I think it is well suited to recommend for migration from Flash component.