Skip to content

Conversation

mperrotti
Copy link
Contributor

@mperrotti mperrotti commented Sep 8, 2025

Relates to https://github.com/github/primer/issues/5424 and https://github.com/github/primer/issues/5425

Changelog

New

Changed

Removed

Rollout strategy

  • Patch release
  • Minor release
  • Major release; if selected, include a written rollout or migration plan
  • None; if selected, include a brief description as to why

Testing & Reviewing

Merge checklist

Copy link

changeset-bot bot commented Sep 8, 2025

🦋 Changeset detected

Latest commit: 07640ac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 2 packages
Name Type
@primer/react Major
@primer/styled-react Major

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Copy link
Contributor

github-actions bot commented Sep 8, 2025

👋 Hi, this pull request contains changes to the source code that github/github depends on. If you are GitHub staff, we recommend testing these changes with github/github using the integration workflow. Thanks!

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 8, 2025
@mperrotti
Copy link
Contributor Author

Opened as a draft because:

  • Need to clean up known problems to not waste reviewers' time
  • Check for usage of sx in dotcom and provide a @primer/react-styled fallback

Copy link
Contributor

github-actions bot commented Sep 8, 2025

size-limit report 📦

Path Size
packages/react/dist/browser.esm.js 89.81 KB (+0.15% 🔺)
packages/react/dist/browser.umd.js 89.93 KB (+0.04% 🔺)

@github-actions github-actions bot requested a deployment to storybook-preview-6805 September 9, 2025 23:55 Abandoned
@mperrotti
Copy link
Contributor Author

This PR is getting way too big. I think I might break it into more parts by taking out the components where I removed sx. Each of these can have their own PR.

@github-actions github-actions bot requested a deployment to storybook-preview-6805 September 10, 2025 13:23 Abandoned
@mperrotti mperrotti marked this pull request as ready for review September 10, 2025 14:22
@Copilot Copilot AI review requested due to automatic review settings September 10, 2025 14:22
@github-actions github-actions bot temporarily deployed to storybook-preview-6805 September 24, 2025 00:35 Inactive
@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 24, 2025
@primer-integration
Copy link

👋 Hi from github/github-ui! Your integration PR is ready: https://github.com/github/github-ui/pull/3160

@primer-integration
Copy link

🟢 ci completed with status success.

@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 24, 2025
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot added integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm and removed integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm labels Sep 26, 2025
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@github-actions github-actions bot removed the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 26, 2025
@mperrotti mperrotti enabled auto-merge September 26, 2025 21:11
@github-actions github-actions bot added the integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm label Sep 26, 2025
Copy link
Contributor

👋 Hi, there are new commits since the last successful integration test. We recommend running the integration workflow once more, unless you are sure the new changes do not affect github/github. Thanks!

@mperrotti mperrotti added this pull request to the merge queue Sep 26, 2025
Merged via the queue into main with commit 0f075d1 Sep 26, 2025
42 checks passed
@mperrotti mperrotti deleted the mp/rm-box-from-components branch September 26, 2025 21:23
@primer primer bot mentioned this pull request Sep 26, 2025
llastflowers pushed a commit that referenced this pull request Sep 29, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

integration-tests: passing Changes in this PR do NOT cause breaking changes in gh/gh integration-tests: recommended This change needs to be tested for breaking changes. See https://arc.net/l/quote/tdmpakpm

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants